Skip to content

Commit 5b8ad0d

Browse files
committed
add closeButtonProps back
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
1 parent d1e7d28 commit 5b8ad0d

2 files changed

Lines changed: 24 additions & 3 deletions

File tree

packages/dialtone-vue2/components/popover/popover.vue

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
:content-class="headerClass"
6969
type="header"
7070
:show-close-button="showCloseButton"
71+
:close-button-props="closeButtonProps"
7172
@close="closePopover"
7273
>
7374
<template #content>
@@ -229,6 +230,14 @@ export default {
229230
default: null,
230231
},
231232
233+
/**
234+
* A set of props to be passed into the popover's header close button.
235+
*/
236+
closeButtonProps: {
237+
type: Object,
238+
default: () => ({}),
239+
},
240+
232241
/**
233242
* Padding size class for the popover content.
234243
* @values none, small, medium, large

packages/dialtone-vue2/components/popover/popover_header_footer.vue

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
importance="outlined"
2929
kind="muted"
3030
circle
31-
v-bind="$ta('CLOSE_BUTTON', { component: 'popover' })"
31+
v-bind="enhancedCloseButtonProps"
3232
@click="$emit('close')"
3333
>
3434
<template #icon>
@@ -78,6 +78,14 @@ export default {
7878
type: Boolean,
7979
default: false,
8080
},
81+
82+
/**
83+
* A set of props to be passed into the close button.
84+
*/
85+
closeButtonProps: {
86+
type: Object,
87+
default: () => {},
88+
},
8189
},
8290
8391
emits: [
@@ -90,9 +98,13 @@ export default {
9098
'close',
9199
],
92100
93-
methods: {
94-
$ta,
101+
computed: {
102+
enhancedCloseButtonProps () {
103+
return Object.assign({}, ...this.closeButtonProps, ...$ta('CLOSE_BUTTON'));
104+
},
105+
},
95106
107+
methods: {
96108
focusCloseButton () {
97109
const closeButton = this.$refs['popover__close-button']?.$el;
98110
closeButton?.focus();

0 commit comments

Comments
 (0)