Skip to content

Commit e1745d4

Browse files
committed
Merge branch 'staging' into next
2 parents 10a0cc8 + 0690180 commit e1745d4

File tree

108 files changed

+3599
-618
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

108 files changed

+3599
-618
lines changed

.claude/commands/pr-fill.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ For all PRs:
9090
For all Vue changes:
9191

9292
- [x] I have added / updated unit tests.
93-
- [ ] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the `./scripts/dialtone-vue-sync.sh` script. Read docs here: [Dialtone Vue Sync Script](../packages/dialtone-vue3/.github/CONTRIBUTING.md#dialtone-vue-sync-script)
9493
- [ ] I have validated components with a screen reader.
9594
- [ ] I have validated components keyboard navigation.
9695

.github/pull_request_template.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ For all PRs:
5858
For all Vue changes:
5959

6060
- [ ] I have added / updated unit tests.
61-
- [ ] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the `./scripts/dialtone-vue-sync.sh` script. Read docs here: [Dialtone Vue Sync Script](../packages/dialtone-vue3/.github/CONTRIBUTING.md#dialtone-vue-sync-script)
6261
- [ ] I have validated components with a screen reader.
6362
- [ ] I have validated components keyboard navigation.
6463

@@ -75,7 +74,7 @@ If new component:
7574

7675
- I am exporting any new components or constants:
7776
- [ ] from the index.js in the component directory.
78-
- [ ] from the index.js in the root (either `packages/dialtone-vue2` or `packages/dialtone-vue3`).
77+
- [ ] from the index.js in the root (like `packages/dialtone-vue3`).
7978
- [ ] I have added the styles for the new component to the `packages/dialtone-css` package.
8079
- [ ] I have created a page for the new component on the documentation site in `apps/dialtone-documentation`.
8180
- [ ] I have added the new component to `common/components_list.js`

.github/workflows/a11y_tests.yml

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,8 @@ jobs:
5959
- name: Check out branch
6060
uses: actions/checkout@v4
6161

62-
- name: Use pnpm
63-
uses: pnpm/action-setup@v3
64-
65-
- name: Use Node.js
66-
uses: actions/setup-node@v4
67-
with:
68-
node-version-file: ".nvmrc"
69-
cache: "pnpm"
70-
registry-url: "https://npm.pkg.github.com"
71-
scope: "dialpad"
72-
env:
73-
NODE_AUTH_TOKEN: ${{ github.token }}
74-
75-
- name: Install dependencies
76-
shell: bash
77-
run: pnpm install --frozen-lockfile
62+
- name: Setup Environment
63+
uses: ./.github/actions/setup-environment
7864

7965
- name: Install Playwright Browsers
8066
run: pnpm exec playwright install --with-deps
@@ -92,22 +78,8 @@ jobs:
9278
- name: Check out branch
9379
uses: actions/checkout@v4
9480

95-
- name: Use pnpm
96-
uses: pnpm/action-setup@v3
97-
98-
- name: Use Node.js
99-
uses: actions/setup-node@v4
100-
with:
101-
node-version-file: ".nvmrc"
102-
cache: "pnpm"
103-
registry-url: "https://npm.pkg.github.com"
104-
scope: "dialpad"
105-
env:
106-
NODE_AUTH_TOKEN: ${{ github.token }}
107-
108-
- name: Install dependencies
109-
shell: bash
110-
run: pnpm install --frozen-lockfile
81+
- name: Setup Environment
82+
uses: ./.github/actions/setup-environment
11183

11284
- name: Install Playwright Browsers
11385
run: pnpm exec playwright install --with-deps

.github/workflows/clean-preview.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ jobs:
1212
id-token: 'write'
1313
env:
1414
DIALTONE_BUCKET_DIRECTORY: dialtone.dialpad.com/deploy-previews/pr-${{ github.event.pull_request.number }}/
15-
DIALTONE_VUE_2_BUCKET_DIRECTORY: dialtone.dialpad.com/vue/deploy-previews/pr-${{ github.event.pull_request.number }}/
16-
DIALTONE_VUE_3_BUCKET_DIRECTORY: dialtone.dialpad.com/vue3/deploy-previews/pr-${{ github.event.pull_request.number }}/
15+
DIALTONE_VUE_3_BUCKET_DIRECTORY: dialtone.dialpad.com/vue/deploy-previews/pr-${{ github.event.pull_request.number }}/
1716
steps:
1817
- uses: actions/checkout@v4
1918

@@ -33,11 +32,6 @@ jobs:
3332
gcloud storage rm --recursive ${{ format('gs://{0}', env.DIALTONE_BUCKET_DIRECTORY) }}
3433
3534
- name: Clean up dialtone-vue preview
36-
continue-on-error: true
37-
run: |
38-
gcloud storage rm --recursive ${{ format('gs://{0}', env.DIALTONE_VUE_2_BUCKET_DIRECTORY) }}
39-
40-
- name: Clean up dialtone-vue3 preview
4135
continue-on-error: true
4236
run: |
4337
gcloud storage rm --recursive ${{ format('gs://{0}', env.DIALTONE_VUE_3_BUCKET_DIRECTORY) }}

.github/workflows/deploy.yml

Lines changed: 9 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ on:
2222
- 'packages/dialtone-tokens/themes/**'
2323
- 'packages/dialtone-tokens/tokens/**'
2424
- 'packages/dialtone-tokens/gulpfile.cjs'
25-
- 'packages/dialtone-vue*/**/*.vue'
26-
- 'packages/dialtone-vue*/**/*.*js'
27-
- 'packages/dialtone-vue*/**/*.stories.js'
25+
- 'packages/dialtone-vue3/**/*.vue'
26+
- 'packages/dialtone-vue3/**/*.*js'
27+
- 'packages/dialtone-vue3/**/*.stories.js'
2828
- '!**/*.test.*js'
2929
pull_request:
3030
paths:
@@ -40,17 +40,16 @@ on:
4040
- 'packages/dialtone-tokens/themes/**'
4141
- 'packages/dialtone-tokens/tokens/**'
4242
- 'packages/dialtone-tokens/gulpfile.cjs'
43-
- 'packages/dialtone-vue*/**/*.vue'
44-
- 'packages/dialtone-vue*/**/*.*js'
45-
- 'packages/dialtone-vue*/**/*.stories.js'
43+
- 'packages/dialtone-vue3/**/*.vue'
44+
- 'packages/dialtone-vue3/**/*.*js'
45+
- 'packages/dialtone-vue3/**/*.stories.js'
4646
- '!**/*.test.*js'
4747

4848
env:
4949
HUSKY: 0
5050
BASE_URL: ${{ github.event_name == 'pull_request' && format('deploy-previews/pr-{0}/', github.event.pull_request.number) || (github.ref_name != 'production' && format('{0}/', github.ref_name)) || '' }}
5151
DIALTONE_BUCKET_DIRECTORY: dialtone.dialpad.com
52-
DIALTONE_VUE_2_BUCKET_DIRECTORY: dialtone.dialpad.com/vue
53-
DIALTONE_VUE_3_BUCKET_DIRECTORY: dialtone.dialpad.com/vue3
52+
DIALTONE_VUE_3_BUCKET_DIRECTORY: dialtone.dialpad.com/vue
5453

5554
concurrency:
5655
group: "${{ github.workflow }}-${{ github.ref }}"
@@ -86,19 +85,6 @@ jobs:
8685
- 'packages/dialtone-tokens/tokens/**'
8786
- 'packages/dialtone-tokens/gulpfile.cjs'
8887
- 'packages/dialtone-vue3/{common,components,directives,localization,recipes}/**/!(*.story.vue|*.test.js|*.stories.js)'
89-
dialtone-vue2:
90-
- 'packages/dialtone-css/**/*.less'
91-
- 'packages/dialtone-css/postcss/*.cjs'
92-
- 'packages/dialtone-css/gulpfile.cjs'
93-
- 'packages/dialtone-emojis/src/**'
94-
- 'packages/dialtone-icons/src/**'
95-
- 'packages/dialtone-icons/gulpfile.cjs'
96-
- 'packages/dialtone-tokens/*.js'
97-
- 'packages/dialtone-tokens/postcss/**'
98-
- 'packages/dialtone-tokens/themes/**'
99-
- 'packages/dialtone-tokens/tokens/**'
100-
- 'packages/dialtone-tokens/gulpfile.cjs'
101-
- 'packages/dialtone-vue2/**'
10288
dialtone-vue3:
10389
- 'packages/dialtone-css/**/*.less'
10490
- 'packages/dialtone-css/postcss/*.cjs'
@@ -130,7 +116,7 @@ jobs:
130116
name: Deploy sites
131117
if: ${{ needs.filter-actions.outputs.packages != '[]' }}
132118
env:
133-
BUCKET_CLEANUP_EXCLUDE: '/alpha/|/beta/|/deploy-previews/|/staging/|/next/|/vue/|/vue3/'
119+
BUCKET_CLEANUP_EXCLUDE: '/alpha/|/beta/|/deploy-previews/|/staging/|/next/|/vue/'
134120
strategy:
135121
fail-fast: false
136122
matrix:
@@ -162,18 +148,13 @@ jobs:
162148
id: expand
163149
env:
164150
DIALTONE_DIST_DIRECTORY: apps/dialtone-documentation/docs/.vuepress/dist
165-
DIALTONE_VUE_2_DIST_DIRECTORY: packages/dialtone-vue2/storybook-static
166151
DIALTONE_VUE_3_DIST_DIRECTORY: packages/dialtone-vue3/storybook-static
167152
run: |
168153
if [[ ${{ matrix.package }} == 'dialtone-documentation' ]]; then
169154
echo "VUEPRESS_BASE_URL=/$BASE_URL" >> $GITHUB_ENV;
170155
echo "source_directory=$DIALTONE_DIST_DIRECTORY" >> $GITHUB_OUTPUT;
171156
echo "dest_directory=$DIALTONE_BUCKET_DIRECTORY/$BASE_URL" >> $GITHUB_OUTPUT;
172157
echo "build_command=dialtone-documentation:build" >> $GITHUB_OUTPUT;
173-
elif [[ ${{ matrix.package }} == 'dialtone-vue2' ]]; then
174-
echo "source_directory=$DIALTONE_VUE_2_DIST_DIRECTORY" >> $GITHUB_OUTPUT;
175-
echo "dest_directory=$DIALTONE_VUE_2_BUCKET_DIRECTORY/$BASE_URL" >> $GITHUB_OUTPUT;
176-
echo "build_command=dialtone-vue2:build-storybook" >> $GITHUB_OUTPUT;
177158
elif [[ ${{ matrix.package }} == 'dialtone-vue3' ]]; then
178159
echo "source_directory=$DIALTONE_VUE_3_DIST_DIRECTORY" >> $GITHUB_OUTPUT;
179160
echo "dest_directory=$DIALTONE_VUE_3_BUCKET_DIRECTORY/$BASE_URL" >> $GITHUB_OUTPUT;
@@ -238,7 +219,6 @@ jobs:
238219
message: |
239220
✔️ Deploy previews ready!
240221
${{ contains(needs.filter-actions.outputs.packages, 'dialtone-documentation') && format('😎 Dialtone documentation preview: https://{0}/{1}', env.DIALTONE_BUCKET_DIRECTORY, env.BASE_URL) }}
241-
${{ contains(needs.filter-actions.outputs.packages, 'dialtone-vue2') && format('😎 Dialtone-vue 2 preview: https://{0}/{1}', env.DIALTONE_VUE_2_BUCKET_DIRECTORY, env.BASE_URL) || '' }}
242-
${{ contains(needs.filter-actions.outputs.packages, 'dialtone-vue3') && format('😎 Dialtone-vue 3 the preview: https://{0}/{1}', env.DIALTONE_VUE_3_BUCKET_DIRECTORY, env.BASE_URL) || '' }}
222+
${{ contains(needs.filter-actions.outputs.packages, 'dialtone-vue3') && format('😎 Dialtone-vue preview: https://{0}/{1}', env.DIALTONE_VUE_3_BUCKET_DIRECTORY, env.BASE_URL) || '' }}
243223
message-id: 'deploy-preview-message'
244224
refresh-message-position: true

.github/workflows/lint-pr.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,8 @@ jobs:
1616
- name: Check out branch
1717
uses: actions/checkout@v4
1818

19-
- name: Use pnpm
20-
uses: pnpm/action-setup@v3
21-
22-
- name: Use Node.js
23-
uses: actions/setup-node@v4
24-
with:
25-
node-version-file: ".nvmrc"
26-
cache: "pnpm"
27-
registry-url: "https://npm.pkg.github.com"
28-
scope: "dialpad"
29-
env:
30-
NODE_AUTH_TOKEN: ${{ github.token }}
31-
32-
- name: Install dependencies
33-
shell: bash
34-
run: pnpm install --frozen-lockfile
19+
- name: Setup Environment
20+
uses: ./.github/actions/setup-environment
3521

3622
- name: Lint pull request title
3723
run: |

.github/workflows/publish-android.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -76,22 +76,8 @@ jobs:
7676
- name: Checkout
7777
uses: actions/checkout@v4
7878

79-
- name: Use pnpm
80-
uses: pnpm/action-setup@v3
81-
82-
- name: Use Node.js
83-
uses: actions/setup-node@v4
84-
with:
85-
node-version-file: ".nvmrc"
86-
cache: "pnpm"
87-
registry-url: "https://npm.pkg.github.com"
88-
scope: "dialpad"
89-
env:
90-
NODE_AUTH_TOKEN: ${{ github.token }}
91-
92-
- name: Install dependencies
93-
shell: bash
94-
run: pnpm install --frozen-lockfile
79+
- name: Setup Environment
80+
uses: ./.github/actions/setup-environment
9581

9682
- name: Setup Java
9783
uses: actions/setup-java@v4

.github/workflows/publish-ios.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,8 @@ jobs:
3131
- name: Checkout
3232
uses: actions/checkout@v4
3333

34-
- name: Use pnpm
35-
uses: pnpm/action-setup@v3
36-
37-
- name: Use Node.js
38-
uses: actions/setup-node@v4
39-
with:
40-
node-version-file: ".nvmrc"
41-
cache: "pnpm"
42-
registry-url: "https://npm.pkg.github.com"
43-
scope: "dialpad"
44-
env:
45-
NODE_AUTH_TOKEN: ${{ github.token }}
46-
47-
- name: Install dependencies
48-
shell: bash
49-
run: pnpm install --frozen-lockfile
34+
- name: Setup Environment
35+
uses: ./.github/actions/setup-environment
5036

5137
- name: Build swift
5238
run: pnpm nx run dialtone-tokens:build:ios

.github/workflows/publish-web.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,18 +116,19 @@ jobs:
116116
runs-on: ubuntu-latest
117117
permissions:
118118
packages: write
119+
id-token: write
119120
steps:
120121
- name: Checkout
121122
uses: actions/checkout@v4
122123

123124
- name: Setup Environment
124125
uses: ./.github/actions/setup-environment
125126

126-
- name: Remove GitHub registry if publishing to npm
127+
- name: Configure registry for publishing
127128
if: matrix.registry == 'npm'
128129
run: |
129-
pnpm config delete @dialpad:registry;
130-
pnpm config set //registry.npmjs.org/:_authToken=${{ secrets.DIALTONE_NPM_TOKEN }}
130+
pnpm config delete @dialpad:registry
131+
pnpm config set registry 'https:${{ matrix.registry_url }}'
131132
132133
- name: Delay job to avoid npm rate limits
133134
if: matrix.package == 'dialtone-vue3'

.github/workflows/release.yml

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
env:
6565
RELEASE_TAG: ${{ needs.get-branch-name.outputs.current_branch == 'staging' && 'latest' || needs.get-branch-name.outputs.current_branch }}
6666
DIALTONE_VUE3_RELEASE_TAG: ${{ needs.get-branch-name.outputs.current_branch == 'staging' && 'vue3' || needs.get-branch-name.outputs.current_branch }}
67-
NPM_TOKEN: ${{ secrets.DIALTONE_NPM_TOKEN }}
6867
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6968
steps:
7069
- name: Checkout
@@ -73,22 +72,8 @@ jobs:
7372
fetch-depth: 0
7473
token: ${{ secrets.DIALTONE_CI_TOKEN }}
7574

76-
- name: Use pnpm
77-
uses: pnpm/action-setup@v3
78-
79-
- name: Use Node.js
80-
uses: actions/setup-node@v4
81-
with:
82-
node-version-file: ".nvmrc"
83-
cache: "pnpm"
84-
registry-url: "https://npm.pkg.github.com"
85-
scope: "dialpad"
86-
env:
87-
NODE_AUTH_TOKEN: ${{ github.token }}
88-
89-
- name: Install dependencies
90-
shell: bash
91-
run: pnpm install --frozen-lockfile
75+
- name: Setup Environment
76+
uses: ./.github/actions/setup-environment
9277

9378
# Release to GitHub
9479
- name: Release Dialtone Combinator ${{ env.RELEASE_TAG }}

0 commit comments

Comments
 (0)