Skip to content

Commit e503c38

Browse files
committed
fix some final missed strings
1 parent dd01d2b commit e503c38

File tree

7 files changed

+31
-29
lines changed

7 files changed

+31
-29
lines changed

apps/dialtone-documentation/docs/components/mode-island.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ keywords: ["theme island","mode override","v-dt-mode","directive","light","dark"
121121
</dt-stack>
122122
<dt-stack direction="row" gap="100" class="d-100p">
123123
<dt-button :size="200" class="d-fl1">Button</dt-button>
124-
<dt-button :size="200" class="d-fl1" kind="danger">Button</dt-button>
124+
<dt-button :size="200" class="d-fl1" kind="critical">Button</dt-button>
125125
</dt-stack>
126126
</dt-stack>
127127
</dt-stack>
@@ -137,7 +137,7 @@ keywords: ["theme island","mode override","v-dt-mode","directive","light","dark"
137137
</dt-stack>
138138
<dt-stack direction="row" gap="100" class="d-100p">
139139
<dt-button :size="200" class="d-fl1">Button</dt-button>
140-
<dt-button :size="200" class="d-fl1" kind="danger">Button</dt-button>
140+
<dt-button :size="200" class="d-fl1" kind="critical">Button</dt-button>
141141
</dt-stack>
142142
</dt-stack>
143143
</dt-stack>
@@ -153,7 +153,7 @@ keywords: ["theme island","mode override","v-dt-mode","directive","light","dark"
153153
</dt-stack>
154154
<dt-stack direction="row" gap="100" class="d-100p">
155155
<dt-button :size="200" class="d-fl1">Button</dt-button>
156-
<dt-button :size="200" class="d-fl1" kind="danger">Button</dt-button>
156+
<dt-button :size="200" class="d-fl1" kind="critical">Button</dt-button>
157157
</dt-stack>
158158
</dt-stack>
159159
</dt-stack>
@@ -374,7 +374,7 @@ A real-world pattern: the callbar container already exists as a semantic element
374374
</dt-stack>
375375
</dt-stack>
376376
<dt-stack class="d-fl1" direction="row" gap="25" justify="center">
377-
<dt-button class="d-px-100 d-w-100" :size="100" kind="danger">
377+
<dt-button class="d-px-100 d-w-100" :size="100" kind="critical">
378378
<template #blockStartIcon> <dt-icon name="mic" size="300" /> </template>
379379
Unmute
380380
</dt-button>
@@ -396,7 +396,7 @@ A real-world pattern: the callbar container already exists as a semantic element
396396
</dt-button>
397397
</dt-stack>
398398
<dt-stack>
399-
<dt-button class="d-p-150" circle :size="400" kind="danger">
399+
<dt-button class="d-p-150" circle :size="400" kind="critical">
400400
<template #startIcon> <dt-icon name="phone-hang-up" size="500" /> </template>
401401
</dt-button>
402402
</dt-stack>

apps/dialtone-documentation/docs/scratch.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ const showTabLabelClass = ref(false);
5050
const resolvedTabLabelClass = computed(() => showTabLabelClass.value ? 'd-bgc-warning' : undefined);
5151
const showInputDescription = ref(false);
5252
const showInputMessages = ref(false);
53-
const inputMessages = computed(() => showInputMessages.value ? [{ message: 'Error validation message', type: 'error' }] : []);
53+
const inputMessages = computed(() => showInputMessages.value ? [{ message: 'Critical validation message', type: 'critical' }] : []);
5454
const showInputMessagesClass = ref(false);
5555
const resolvedInputMessagesClass = computed(() => showInputMessagesClass.value ? 'd-bgc-critical' : undefined);
5656
const showInputDescriptionClass = ref(false);
5757
const resolvedInputDescriptionClass = computed(() => showInputDescriptionClass.value ? 'd-bgc-success' : undefined);
5858
const showDescription = ref(false);
5959
const showCheckRadioMessages = ref(false);
60-
const checkRadioMessages = computed(() => showCheckRadioMessages.value ? [{ message: 'Error validation message', type: 'error' }] : []);
60+
const checkRadioMessages = computed(() => showCheckRadioMessages.value ? [{ message: 'Critical validation message', type: 'critical' }] : []);
6161
const showCheckRadioMessagesClass = ref(false);
6262
const resolvedCheckRadioMessagesClass = computed(() => showCheckRadioMessagesClass.value ? 'd-bgc-critical' : undefined);
6363
const showCheckRadioDescriptionClass = ref(false);
@@ -169,9 +169,9 @@ const checkRadioDisabled = ref(false);
169169
<dt-button :disabled="isDisabled" importance="clear"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
170170
</dt-stack>
171171
<dt-stack gap="100" :direction="{ 'default': 'column', 'md': 'row' }">
172-
<dt-button :disabled="isDisabled" kind="danger"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
173-
<dt-button :disabled="isDisabled" kind="danger" importance="outlined"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
174-
<dt-button :disabled="isDisabled" kind="danger" importance="clear"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
172+
<dt-button :disabled="isDisabled" kind="critical"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
173+
<dt-button :disabled="isDisabled" kind="critical" importance="outlined"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
174+
<dt-button :disabled="isDisabled" kind="critical" importance="clear"> Place Call <template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
175175
</dt-stack>
176176
<dt-stack gap="100" :direction="{ 'default': 'column', 'md': 'row' }">
177177
<dt-button :disabled="isDisabled" kind="positive">Place Call<template #startIcon="{ iconSize }"> <dt-icon name="box-select" :size="iconSize" /> </template></dt-button>
@@ -850,7 +850,7 @@ const checkRadioDisabled = ref(false);
850850
<dt-notice kind="warning" title="Warning" hide-action>
851851
Please review before proceeding.
852852
</dt-notice>
853-
<dt-notice kind="error" title="Error" hide-action>
853+
<dt-notice kind="critical" title="Critical" hide-action>
854854
Something went wrong. Please try again.
855855
</dt-notice>
856856
<dt-notice kind="base" title="Base" hide-action>
@@ -868,7 +868,7 @@ const checkRadioDisabled = ref(false);
868868
<dt-notice kind="warning" title="Important warning" :important="true" hide-action>
869869
Visually prominent variant with filled background.
870870
</dt-notice>
871-
<dt-notice kind="error" title="Important error" :important="true" hide-action>
871+
<dt-notice kind="critical" title="Important critical" :important="true" hide-action>
872872
Visually prominent variant with filled background.
873873
</dt-notice>
874874
</dt-stack>
@@ -898,7 +898,7 @@ const checkRadioDisabled = ref(false);
898898
<dt-banner kind="warning" title="Warning banner" class="d-ps-relative d-zi-base">
899899
Please review before proceeding.
900900
</dt-banner>
901-
<dt-banner kind="error" title="Error banner" class="d-ps-relative d-zi-base">
901+
<dt-banner kind="critical" title="Critical banner" class="d-ps-relative d-zi-base">
902902
Something went wrong.
903903
</dt-banner>
904904
</dt-stack>
@@ -913,7 +913,7 @@ const checkRadioDisabled = ref(false);
913913
<dt-banner kind="warning" title="Warning banner" :important="true" class="d-ps-relative d-zi-base">
914914
Please review before proceeding.
915915
</dt-banner>
916-
<dt-banner kind="error" title="Error banner" :important="true" class="d-ps-relative d-zi-base">
916+
<dt-banner kind="critical" title="Critical banner" :important="true" class="d-ps-relative d-zi-base">
917917
Something went wrong.
918918
</dt-banner>
919919
</dt-stack>
@@ -928,15 +928,15 @@ const checkRadioDisabled = ref(false);
928928
<dt-toast :show="true" kind="info" title="Info toast" message="Informational message." :duration="null" />
929929
<dt-toast :show="true" kind="success" title="Success toast" message="Action completed." :duration="null" />
930930
<dt-toast :show="true" kind="warning" title="Warning toast" message="Review before proceeding." :duration="null" />
931-
<dt-toast :show="true" kind="error" title="Error toast" message="Something went wrong." :duration="null" />
931+
<dt-toast :show="true" kind="critical" title="Critical toast" message="Something went wrong." :duration="null" />
932932
<dt-toast :show="true" kind="base" title="Base toast" message="Neutral notification." :duration="null" />
933933
</dt-stack>
934934
<dt-stack gap="100">
935935
<dt-text as="h3" kind="headline" :size="300">Important</dt-text>
936936
<dt-toast :show="true" kind="info" title="Info toast" message="Informational message." :important="true" :duration="null" />
937937
<dt-toast :show="true" kind="success" title="Success toast" message="Action completed." :important="true" :duration="null" />
938938
<dt-toast :show="true" kind="warning" title="Warning toast" message="Review before proceeding." :important="true" :duration="null" />
939-
<dt-toast :show="true" kind="error" title="Error toast" message="Something went wrong." :important="true" :duration="null" />
939+
<dt-toast :show="true" kind="critical" title="Critical toast" message="Something went wrong." :important="true" :duration="null" />
940940
<dt-toast :show="true" kind="base" title="Base toast" message="Neutral notification." :important="true" :duration="null" />
941941
</dt-stack>
942942
<dt-stack gap="100">

packages/combinator/src/variants/variants_checkbox_group.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default {
2121
props: {
2222
name: { initialValue: 'validated-checkbox-group' },
2323
legend: { initialValue: 'Fruits' },
24-
messages: { initialValue: [{ message: 'Please select at least one option.', type: 'error' }] },
24+
messages: { initialValue: [{ message: 'Please select at least one option.', type: 'critical' }] },
2525
},
2626
slots: {
2727
default: {

packages/combinator/src/variants/variants_input.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable max-len */
1+
22

33

44
export default {
@@ -170,7 +170,7 @@ export default {
170170
props: {
171171
label: { initialValue: 'Label' },
172172
type: { initialValue: 'email' },
173-
messages: { initialValue: [{ message: 'Please enter a valid email address.', type: 'error' }] },
173+
messages: { initialValue: [{ message: 'Please enter a valid email address.', type: 'critical' }] },
174174
},
175175
},
176176
};

packages/combinator/src/variants/variants_radio_group.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default {
2020
props: {
2121
name: { initialValue: 'validated-radio-group' },
2222
legend: { initialValue: 'Fruits' },
23-
messages: { initialValue: [{ message: 'Please select an option.', type: 'error' }] },
23+
messages: { initialValue: [{ message: 'Please select an option.', type: 'critical' }] },
2424
},
2525
slots: {
2626
default: {

packages/combinator/src/variants/variants_validation_messages.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
/* eslint-disable max-len */
1+
22

33
export default {
44
default: {
55
props: {
66
validationMessages: {
7-
initialValue: [{ message: 'Positive validation message', type: 'success' }],
7+
initialValue: [{ message: 'Positive validation message', type: 'positive' }],
88
},
99
},
1010
},
1111
'with error': {
1212
props: {
1313
validationMessages: {
14-
initialValue: [{ message: 'Error validation message', type: 'error' }],
14+
initialValue: [{ message: 'Critical validation message', type: 'critical' }],
1515
},
1616
},
1717
},
@@ -26,8 +26,8 @@ export default {
2626
props: {
2727
validationMessages: {
2828
initialValue: [
29-
{ message: 'First error message', type: 'error' },
30-
{ message: 'Second error message', type: 'error' },
29+
{ message: 'First error message', type: 'critical' },
30+
{ message: 'Second error message', type: 'critical' },
3131
],
3232
},
3333
},

packages/dialtone-docs/src/content/reference/reference-component-api-patterns.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ Exceptions exist — DtModal uses `default` and `full` instead.
4242

4343
Color or semantic variant. Values vary per component:
4444

45-
- DtButton: `default`, `muted`, `danger`, `positive`, `inverted`, `unstyled`
46-
- DtModal: `default`, `danger`
47-
- DtNotice: `base`, `error`, `info`, `success`, `warning`
48-
- DtBadge: uses `type` instead (`default`, `info`, `success`, `warning`, `critical`, `bulletin`, `ai`)
45+
- DtButton: `default`, `muted`, `critical`, `positive`, `inverted`, `unstyled`
46+
- DtModal: `default`, `critical`
47+
- DtNotice: `base`, `critical`, `info`, `positive`, `warning`
48+
- DtBadge: uses `type` instead (`default`, `info`, `positive`, `warning`, `critical`, `bulletin`, `ai`)
4949

5050
### Importance
5151

@@ -143,11 +143,13 @@ Icon scale values correspond to pixel sizes defined in `packages/dialtone-icons/
143143
Group-child relationships use Vue's provide/inject. The parent provides a reactive context object plus action methods:
144144

145145
**Tab group** (`tab_group.vue`):
146+
146147
```
147148
provides: { groupContext: { selected, disabled }, setFocus }
148149
```
149150

150151
**Input groups** (CheckboxGroup, RadioGroup via `input_group.js` mixin):
152+
151153
```
152154
provides: { groupContext: { name, disabled, validationState, value, selectedValues }, setGroupValue }
153155
```

0 commit comments

Comments
 (0)