Skip to content

Commit 8185a5e

Browse files
Fix logger in hf secret source
1 parent 15b941e commit 8185a5e

4 files changed

Lines changed: 12 additions & 4 deletions

File tree

pkg/cmd/agent/submit.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ func NewSubmitCmd(logger *log.Logger) *cobra.Command {
3535
name = ""
3636
version = ""
3737
)
38-
submissionConfig.RegisterCredentialsProviders()
3938

4039
c, err := diambra.NewConfig(logger)
4140
if err != nil {
4241
level.Error(logger).Log("msg", err.Error())
4342
os.Exit(1)
4443
}
44+
submissionConfig.RegisterCredentialsProviders(logger, c.Home)
4545

4646
cmd := &cobra.Command{
4747
Use: "submit [flags] (directory | --submission.manifest=submission-manifest.yaml | docker-image) [args/command(s) ...]",

pkg/cmd/agent/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ const (
2424

2525
func NewTestCmd(logger *log.Logger) *cobra.Command {
2626
submissionConfig := diambra.SubmissionConfig{}
27-
submissionConfig.RegisterCredentialsProviders()
2827
c, err := diambra.NewConfig(logger)
2928
if err != nil {
3029
level.Error(logger).Log("msg", err.Error())
3130
os.Exit(1)
3231
}
32+
submissionConfig.RegisterCredentialsProviders(logger, c.Home)
3333

3434
cmd := &cobra.Command{
3535
Use: "test [flags] {--submission.manifest submission-manifest.yaml | docker-image} [args/command(s) ...]",

pkg/diambra/config.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,9 @@ func (c *SubmissionConfig) RegisterCredentialsProvider(name string, provider sec
254254
}
255255
c.credentialsProvider[name] = provider
256256
}
257-
func (c *SubmissionConfig) RegisterCredentialsProviders() {
257+
func (c *SubmissionConfig) RegisterCredentialsProviders(logger log.Logger, home string) {
258258
c.RegisterCredentialsProvider("git", &secretsources.GitCredentials{})
259-
c.RegisterCredentialsProvider("huggingface", &secretsources.HuggingfaceCredentials{})
259+
c.RegisterCredentialsProvider("huggingface", secretsources.NewHuggingfaceCredentials(logger, home))
260260
}
261261

262262
func (c *SubmissionConfig) AddFlags(flags *pflag.FlagSet) {
@@ -346,6 +346,7 @@ func (c *SubmissionConfig) Submission(config *EnvConfig, args []string) (*client
346346
if !ok {
347347
return nil, fmt.Errorf("invalid value for --submission.secrets-from: %s", c.SecretsFrom)
348348
}
349+
349350
switch c.SecretsFrom {
350351
case "git":
351352
secrets, err := secretsources.CredentialsFill(ss, manifest.Sources)

pkg/secretsources/huggingface.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@ type HuggingfaceCredentials struct {
2525
Home string
2626
}
2727

28+
func NewHuggingfaceCredentials(logger log.Logger, home string) *HuggingfaceCredentials {
29+
return &HuggingfaceCredentials{
30+
logger: logger,
31+
Home: home,
32+
}
33+
}
34+
2835
func (c *HuggingfaceCredentials) Credentials(url string) (map[string]string, error) {
2936
cmd := exec.Command(pyarena.FindPython(), "-c", GetHuggingfaceToken)
3037
stdout := &bytes.Buffer{}

0 commit comments

Comments
 (0)