[Bug]: `:: fatal: detected dubious ownership in repository at '/data'`

[Saviq]

What happened?

Using git inside override-*: scriptlets tends to result in:

:: fatal: detected dubious ownership in repository at '/data'

E.g. https://github.com/MirServer/confined-shell-wip/actions/runs/4425288703/jobs/7760152845

What should have happened?

The project needs to be fed into the container in a way that git is happy with it.

Output of snap info $snap_name

N/A

Output of snap connections $snap_name

N/A

Output of snap version

N/A

Relevant log output

:: ++ git -C /data rev-list --count HEAD
:: fatal: detected dubious ownership in repository at '/data'
:: To add an exception for this directory, call:
::
:: 	git config --global --add safe.directory /data

### Teminal output of app

_No response_

[MirkoFerrati]

@Saviq I was testing locally without any docker involved and got the same issue, it's not a bug in this action, it's git version getting updated. See my fix here MirkoFerrati/micro-ROS-Agent@f9fa340 or take a look at https://weblog.west-wind.com/posts/2023/Jan/05/Fix-that-damn-Git-Unsafe-Repository and https://community.rocketsoftware.com/discussion/git-safedirectory-check-in-2262-87
People are fixing this like bhoung/bhoung.github.io@92cae7d or actions/runner@d61b27b

[Saviq]

@MirkoFerrati right… thanks, will try a workaround o/

[Saviq]

Finally got back to this and this seems like a safe enough workaround:

override-pull: |
  craftctl default
  git config --global --add safe.directory ${CRAFT_PROJECT_DIR}

I still believe the action should make sure that it's not necessary (along what actions/runner@d61b27b did).