🧪 Test AnonCreds revocation (#1401)

* 🧪 Test AnonCreds revocation

* 🧪 Test proof revoked credential for anoncreds

* 🧪 Indy/AnonCreds proof types

* 🧪 Assert expected error; drop unnecessary test

* 🎨 Consistent return types

* ✨ Create transaction for endorser

* 🔊 Log to debug 422 error

* 🧪 Update tests

* ✅ Fix unit test

* 🐛 Fix iterating txns

* ✅

* 🚧 Test with added log

* 🎨 Default empty list

* 🚧 Test cloudcontroller with `rrid2crid` int fix

didx-xyz/aries-cloudcontroller-python#241

* 🎨 Modify expected types

* 🐛 Fix iterating None type

* 🧪 Add sleep to account for anoncreds not providing transaction id to await acknowledgement

* ⏪ Revert test acapy image

* ⬆️ Use latest cloudcontroller

* ⬆️ Update lock files

* 🧪 Increase sleep for revoke check

* ✅ Test coverage for empty response

* 🧪 Skip broken test

* 🎨 Fix fixture name

* ⬆️ Update lock files

Author: ff137

app/models/issuer.py

@@ -133,7 +133,7 @@ def extract_revoked_info(
     ) -> Dict[str, Any]:
         if isinstance(values, dict) and "txn" in values:
             # This is a List of TransactionRecord
-            txn_list: List[Dict[str, Any]] = values.get("txn")
+            txn_list: List[Dict[str, Any]] = values.get("txn") or []
             cred_rev_ids_published = {}
 
             for txn in txn_list:

app/poetry.lock

@@ -13,7 +13,7 @@ python = "~3.12.8"
 
 aiohttp = "~3.11.7"
 aiocache = "~0.12.0"
-aries-cloudcontroller = "==1.2.1.post20250228"
+aries-cloudcontroller = "==1.2.1.post20250319"
 base58 = "~2.1.1"
 fastapi = "~0.115.10"
 httpx = "~0.28.0"

app/pyproject.toml

@@ -197,9 +197,9 @@ async def publish_revocations(
             bound_logger.debug("No revocations to publish.")
             return RevokedResponse()
 
-        # TODO The anoncreds response seems to be broken, looks like agent response model not what it's
-        # supposed to be. Need to investigate further.
-        endorser_transaction_ids = [txn.transaction_id for txn in result.txn]
+        endorser_transaction_ids = (
+            [txn.transaction_id for txn in result.txn] if result.txn else []
+        )
         for endorser_transaction_id in endorser_transaction_ids:
             bound_logger.debug(
                 "Wait for publish complete on transaction id: {}",

app/routes/revocation.py

@@ -9,6 +9,8 @@
     IssuerCredRevRecord,
     IssuerRevRegRecord,
     PublishRevocations,
+    PublishRevocationsOptions,
+    PublishRevocationsResultSchemaAnoncreds,
     PublishRevocationsSchemaAnoncreds,
     RevokeRequest,
     RevokeRequestSchemaAnoncreds,
@@ -200,7 +202,7 @@ async def revoke_credential(
 
 async def publish_pending_revocations(
     controller: AcaPyClient, revocation_registry_credential_map: Dict[str, List[str]]
-) -> TxnOrPublishRevocationsResult:
+) -> Optional[TxnOrPublishRevocationsResult]:
     """
         Publish pending revocations
 
@@ -226,7 +228,8 @@ async def publish_pending_revocations(
         if wallet_type == "askar-anoncreds":
             acapy_call = controller.anoncreds_revocation.publish_revocations
             body = PublishRevocationsSchemaAnoncreds(
-                rrid2crid=revocation_registry_credential_map
+                rrid2crid=revocation_registry_credential_map,
+                options=PublishRevocationsOptions(create_transaction_for_endorser=True),
             )
         else:  # wallet_type == "askar":
             acapy_call = controller.revocation.publish_revocations
@@ -242,20 +245,37 @@ async def publish_pending_revocations(
             f"Failed to publish pending revocations: {e.detail}", e.status_code
         ) from e
 
-    if not result.txn or not result.txn[0].transaction_id:
+    if isinstance(result, TxnOrPublishRevocationsResult):
+        if not result.txn or not result.txn[0].transaction_id:
+            bound_logger.warning(
+                "Published pending revocations but received no endorser transaction id. Got result: {}",
+                result,
+            )
+            return
+
+        bound_logger.debug(
+            "Successfully published pending Indy revocations. Endorser transaction ids: {}.",
+            [txn.transaction_id for txn in result.txn],
+        )
+        return result
+    elif isinstance(result, PublishRevocationsResultSchemaAnoncreds):
+        bound_logger.info(
+            "Successfully published pending AnonCreds revocations: {}.", result
+        )
+        # Cast integer cred_rev_ids to string
+        rrid2crid = result.rrid2crid if result.rrid2crid else {}
+        rrid2crid = {k: [str(i) for i in v] for k, v in result.rrid2crid.items()}
+        return TxnOrPublishRevocationsResult(
+            rrid2crid=rrid2crid,
+            txn=None,
+        )
+    else:
         bound_logger.warning(
-            "Published pending revocations but received no endorser transaction id. Got result: {}",
+            "Unexpected response from publish_revocations: `{}`. Perhaps empty publish request?",
             result,
         )
         return
 
-    endorse_transaction_ids = [txn.transaction_id for txn in result.txn]
-    bound_logger.debug(
-        "Successfully published pending revocations. Endorser transaction ids: {}.",
-        endorse_transaction_ids,
-    )
-    return result
-
 
 async def clear_pending_revocations(
     controller: AcaPyClient, revocation_registry_credential_map: Dict[str, List[str]]