SplitTabWidget: better handling of spliting out (#131)

Properly parent tabs when moving widgets between splits. Fixes a crash,
and widgets being deleted on some scenarios.

closes #131

Author: diegoiast

src/widgets/SplitTabWidget.cpp

@@ -449,8 +449,12 @@ void SplitTabWidget::moveTabToNewSplit(QWidget *widget) {
     auto oldTab = qobject_cast<QTabWidget *>(widget->parentWidget()->parentWidget());
     auto index = oldTab->indexOf(widget);
     auto text = oldTab->tabText(index);
-    currentTabWidget->addTab(widget, text);
-    oldTab->removeTab(index);
+    auto tooltip = oldTab->tabToolTip(index);
+
+    // The widget is automatically removed from oldTab when reparented
+    auto newIndex = currentTabWidget->addTab(widget, text);
+    currentTabWidget->setTabToolTip(newIndex, tooltip);
+    currentTabWidget->setCurrentIndex(newIndex);
     widget->setFocus();
 }