Skip to content

Commit 3016ff4

Browse files
jeromedockesdierickxsimon
authored andcommitted
fix test after scikit-learn 1.8 (skrub-data#1682)
1 parent ea0c1c5 commit 3016ff4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

skrub/_data_ops/tests/test_estimators.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,8 @@ def test_estimator_type(estimator_type, expected, bury_apply):
738738
e.skb.make_randomized_search(n_iter=2),
739739
]:
740740
Xy_pipe = pipe.__skrub_to_Xy_pipeline__({})
741-
assert Xy_pipe._estimator_type == expected
741+
if hasattr(estimator, "_estimator_type"):
742+
assert Xy_pipe._estimator_type == expected
742743
if hasattr(estimator_type, "__sklearn_tags__"):
743744
# scikit-learn >= 1.6
744745
assert Xy_pipe.__sklearn_tags__() == estimator.__sklearn_tags__()

0 commit comments

Comments
 (0)