Now sqlite feature is enabled when returning_clauses_for_sqlite_3_35 is enabled

Author: LucaCappelletti94

diesel/Cargo.toml

@@ -88,7 +88,7 @@ ipnet-address = ["dep:ipnet", "dep:libc"]
 numeric = ["dep:num-bigint", "dep:bigdecimal", "dep:num-traits", "dep:num-integer", "diesel_derives/numeric"]
 postgres_backend = ["diesel_derives/postgres", "dep:bitflags", "dep:byteorder", "dep:itoa"]
 mysql_backend = ["diesel_derives/mysql", "dep:byteorder"]
-returning_clauses_for_sqlite_3_35 = []
+returning_clauses_for_sqlite_3_35 = ["sqlite"]
 i-implement-a-third-party-backend-and-opt-into-breaking-changes = []
 r2d2 = ["diesel_derives/r2d2", "dep:r2d2"]
 chrono = ["diesel_derives/chrono", "dep:chrono"]

diesel_tests/tests/insert.rs

@@ -152,7 +152,7 @@ fn insert_records_as_boxed_static_array() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn insert_record_using_returning_clause() {
     use crate::schema::users::table as users;
     let connection = &mut connection();
@@ -172,7 +172,7 @@ fn insert_record_using_returning_clause() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn insert_record_attached_database_using_returning_clause() {
     table! {
         external.external_table (id) {
@@ -220,7 +220,7 @@ fn insert_record_attached_database_using_returning_clause() {
 
 #[diesel_test_helper::test]
 #[cfg(not(any(
-    not(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35")),
+    not(feature = "returning_clauses_for_sqlite_3_35"),
     feature = "mysql"
 )))]
 fn insert_records_using_returning_clause() {
@@ -252,7 +252,7 @@ fn insert_records_using_returning_clause() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn insert_record_with_custom_returning_clause() {
     use crate::schema::users::dsl::*;
 
@@ -568,7 +568,7 @@ fn upsert_empty_slice() {
 #[diesel_test_helper::test]
 #[cfg(any(
     feature = "postgres",
-    all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35")
+    feature = "returning_clauses_for_sqlite_3_35"
 ))]
 fn insert_only_default_values_with_returning() {
     use crate::schema::users::id;
@@ -833,7 +833,7 @@ fn batch_insert_is_atomic_on_sqlite() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn batch_insert_with_returning_is_atomic_on_sqlite() {
     use crate::schema::users::dsl::*;
     let connection = &mut connection();
@@ -848,7 +848,7 @@ fn batch_insert_with_returning_is_atomic_on_sqlite() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn batch_insert_with_defaultables_and_returning_is_atomic_on_sqlite() {
     use crate::schema::users::dsl::*;
     let connection = &mut connection();
@@ -863,7 +863,7 @@ fn batch_insert_with_defaultables_and_returning_is_atomic_on_sqlite() {
 }
 
 #[diesel_test_helper::test]
-#[cfg(all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35"))]
+#[cfg(feature = "returning_clauses_for_sqlite_3_35")]
 fn batch_upsert_with_defaultables_and_returning_is_atomic_on_sqlite() {
     use crate::schema::users::dsl::*;
     let connection = &mut connection();
@@ -1022,7 +1022,7 @@ fn batch_upsert_non_default_values() {
 #[diesel_test_helper::test]
 #[cfg(any(
     feature = "postgres",
-    all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35")
+    feature = "returning_clauses_for_sqlite_3_35"
 ))]
 fn batch_upsert_with_returning() {
     use crate::schema::users;

diesel_tests/tests/update.rs

@@ -381,7 +381,7 @@ fn upsert_with_sql_literal_for_target() {
 #[diesel_test_helper::test]
 #[cfg(any(
     feature = "postgres",
-    all(feature = "sqlite", feature = "returning_clauses_for_sqlite_3_35")
+    feature = "returning_clauses_for_sqlite_3_35"
 ))]
 fn upsert_for_target_with_condition() {
     use crate::schema::comments::dsl::*;