You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the new QueryModel derive introduced in #4600 it's an open question if we want to default to generating the relevant code for #[diesel(check_for_backend()] for all backends enabled at compilation time.
From my point of view the advantage of doing that automatically are much better error messages. The disadvantage is that this likely won't work in code-bases that support multiple backends or use a non-default backend (e.g. third party backends or #[derive(MultiConnection)]. For the later case manual annotations would be still required.
How to handle `#[diesel(check_for_backend(_)]`
Enable by default, allow to optionally overwrite
33%
Enable by default, allow to optionally overwrite and to optionally disable
50%
Require manual annotations as for `#[derive(Selectable)]`
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
For the new
QueryModelderive introduced in #4600 it's an open question if we want to default to generating the relevant code for#[diesel(check_for_backend()]for all backends enabled at compilation time.From my point of view the advantage of doing that automatically are much better error messages. The disadvantage is that this likely won't work in code-bases that support multiple backends or use a non-default backend (e.g. third party backends or
#[derive(MultiConnection)]. For the later case manual annotations would be still required.6 votes ·
Beta Was this translation helpful? Give feedback.
All reactions