List of cleanup locations marked as `DEPRECATED`

[NlightNFotis]

Hello,

As part of the v6 release work, we're looking into some code cleanup actions. One of them is removing code locations marked as DEPRECATED. What follows is a list we have compiled, for better tracking of the effort across the community, along with some notes from our original investigation:

• src/analyses/ai_storage.h - #8007
  • NOTE: painful - no direct substitute?
• src/analyses/ai.h - #8008
  • NOTE: painful - no direct substitute?
• src/analyses/ai.h - virtual statet &get_state #8009
• src/goto-instrument/wmm/goto2graph.h - bool is_cfg_spurious #8010
• src/goto-programs/class_hierarchy.h - #8011
  • deprecate over class_hierarchy_grapht - make abstract or otherwise
    uninitialisable?
• src/goto-programs/goto_model.h - public symbol_table and public goto_functions #8012
• src/solvers/strings/string_concatenation_builtin_function.cpp - string_constraint_generatort::add_axioms_for_concat #8013
• src/solvers/strings/string_concatenation_builtin_function.cpp - string_constraint_generatort::add_axioms_for_concat_code_point #8014
• src/solvers/strings/string_constraint_generator_main.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_for_copy #8018
• src/solvers/strings/string_constraint_generator_testing.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_for_is_empty #8019
• src/solvers/strings/string_constraint_generator_testing.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_for_is_suffix #8020
• src/solvers/strings/string_constraint_generator_valueof.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_from_long #8021
• src/solvers/strings/string_constraint_generator_valueof.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_from_bool #8022
• src/solvers/strings/string_constraint_generator_valueof.cpp - pair<exprt, string_constraints> string_constraint_generatort::add_axioms_from_int_hex #8023
• src/solvers/strings/string_constraint_generator.h - #8024
  • marked as Java specific?
• src/solvers/strings/string_constraint_generator.h - #8025
  • marked as Java specific?
• src/util/c_types.h - index_type()
  • Done at remove index_type() #7992
• src/util/expr_util.h #8015
  • whole file marked deprecated but still widely used?
• src/util/lispexpr.h #8016
  • whole file marked deprecated
• src/util/message.h - messaget() (empty messaget constructor) #8017
• src/util/source_location.h - set_function and get_function #8026
  • NOTE: extremely painful to remove, far reaching integration into codebase
• src/util/string_constant.h - get_value() and set_value()
  • Done at Refactor string_constantt::get_value and string_constantt::set_value call sites. #7999
• src/goto-analyzer/static_verifier.cpp - calls to x.set_attribute? #8027

[tautschnig]

• For get_function(): label_properties: do not rely on source_locationt's get_function() #4131 and Remove function from source_locationt [depends-on: #4131] #3514 for a start.
• For messaget(): languaget is not a messaget [blocks: #3800] #4050.

And then there, of course, is #3800 as an over-arching effort to make this cleanup happen.

[TGWDB]

There is a (as yet unpopulated) project board that may make it easier to coordinate on this here: Removed `DEPRECATED` code (view)