Commit 98b0b1b
committed
Lazily initialize GitRatchetGradle to avoid loading JGit at configuration time
GitRatchetGradle is instantiated eagerly when SpotlessTaskService is
created, which happens during Gradle configuration. Its static
initializer installs a custom JGit SystemReader that reads
~/.gitconfig. This causes Gradle's configuration cache to fingerprint
the file even when no Spotless tasks are requested.
Defer instantiation to getRatchet(), which is only called during task
execution. This avoids loading JGit classes and reading git config
files at configuration time.1 parent 46b8770 commit 98b0b1b
2 files changed
Lines changed: 34 additions & 2 deletions
File tree
- plugin-gradle/src
- main/java/com/diffplug/gradle/spotless
- test/java/com/diffplug/gradle/spotless
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
105 | 108 | | |
106 | 109 | | |
107 | 110 | | |
| |||
112 | 115 | | |
113 | 116 | | |
114 | 117 | | |
115 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
116 | 121 | | |
117 | 122 | | |
118 | 123 | | |
| |||
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
63 | 90 | | |
64 | 91 | | |
65 | 92 | | |
| |||
0 commit comments