Skip to content

Decouple PRService from digger config reading #1051

Open
@ZIJ

Description

@ZIJ

Currently PRService is created as part of reading digger config
Which doesn't allow to report an error to the user if smth goes wrong in reading digger config
That is bad because at this point there is no other way to report an error (the job hasn't started yet)
So we want to refactor it to be able to report errors as comments as early as possible

ghService, config, projectsGraph, branch, err := getDiggerConfig(gh, installationId, repoFullName, repoOwner, repoName, cloneURL, prNumber)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions