fix: Support case insensitive digger commands #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motatoes
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Please also make the change in gitlab flow:
Line 325 in ac7c2ef
|
@veziak next time you should see the assignees of an issue before opening a PR. i was assigned and worked on it. why did you open a PR then? |
|
Hi @tarunsamanta2k20 , apologies! I should have communicated it better. We wanted that feature to be included into the release we created yesterday and it was easier to create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #344
Issue Description:
Requested by user:
Digger commentOps currently only work with exact lowercase "digger plan", "digger apply" etc.
Digger should be able to also support case insensitve commands such as "Digger plan" and so on since it is more forgiving.
Proposal: make digger case insensitive by default, allow users to make it case sensitive through some parameter passed into composite action case-sensitve (defaults to false)