Skip to content

Commit 8f4eea6

Browse files
canton-machinergugliel-da
authored andcommitted
[release-line-3.3] Update 2025-05-06.23
Reference commit: 4f9bd42580
1 parent 3511708 commit 8f4eea6

File tree

278 files changed

+7552
-10028
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

278 files changed

+7552
-10028
lines changed

UNRELEASED.md

Lines changed: 1 addition & 1486 deletions
Large diffs are not rendered by default.

community/app-base/src/main/scala/com/digitalasset/canton/config/CantonConfig.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1949,8 +1949,7 @@ object CantonConfig {
19491949
.foldLeft(c) { case (subConfig, (key, obj)) =>
19501950
subConfig.withValue(key, goVal(key, obj))
19511951
}
1952-
go(config)
1953-
.resolve()
1952+
go(config.resolve()) // Resolve the config _before_ redacting confidential information
19541953
.root()
19551954
.get("canton")
19561955
.render(CantonConfig.defaultConfigRenderer)

community/app/src/test/daml/CantonLfDev/daml.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
sdk-version: 3.3.0-snapshot.20250415.13756.0.vafc5c867
1+
sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
22
build-options:
33
- --target=2.dev
44
name: CantonLfDev

community/app/src/test/daml/CantonLfV21/daml.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
sdk-version: 3.3.0-snapshot.20250415.13756.0.vafc5c867
1+
sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
22
build-options:
33
- --target=2.1
44
- --enable-interfaces=yes

community/app/src/test/daml/CantonTest/daml.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
sdk-version: 3.3.0-snapshot.20250415.13756.0.vafc5c867
1+
sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
22
build-options:
33
- --target=2.1
44
name: CantonTests

community/app/src/test/daml/CantonTestDev/daml.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
sdk-version: 3.3.0-snapshot.20250415.13756.0.vafc5c867
1+
sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
22
build-options:
33
- --target=2.dev
44
name: CantonTestsDev

community/app/src/test/scala/com/digitalasset/canton/integration/tests/bftsynchronizer/SequencerOnboardingTombstoneTest.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ trait SequencerOnboardingTombstoneTest
9595
participant1.ledger_api.javaapi.commands.submit_async(
9696
Seq(participant1.id.adminParty),
9797
cycle,
98-
commandId = "commandId",
98+
commandId = "long-running-tx-id",
9999
)
100100

101101
// Make sure that the participant's request has reached the sequencer
@@ -146,7 +146,7 @@ trait SequencerOnboardingTombstoneTest
146146
loggerFactory.assertLogsUnorderedOptional(
147147
{
148148

149-
clue("participant1 connects to sequencer2") {
149+
clue("participant1 connects to sequencer2 the first time") {
150150
participant1.synchronizers.reconnect_all(ignoreFailures = false)
151151
}
152152

@@ -248,7 +248,7 @@ trait SequencerOnboardingTombstoneTest
248248
sequencer2.sequencerConnection.withAlias(SequencerAlias.tryCreate("seq2x")),
249249
)
250250

251-
clue("participant1 connects to sequencer2") {
251+
clue("participant1 connects to sequencer2 the second time") {
252252
participant1.synchronizers.reconnect_all(ignoreFailures = false)
253253
}
254254

community/app/src/test/scala/com/digitalasset/canton/integration/tests/bftsynchronizer/SimpleFunctionalNodesTest.scala

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@ import com.digitalasset.canton.config
88
import com.digitalasset.canton.config.DbConfig
99
import com.digitalasset.canton.console.CommandFailure
1010
import com.digitalasset.canton.console.commands.SynchronizerChoice
11-
import com.digitalasset.canton.integration.plugins.{UseCommunityReferenceBlockSequencer, UseH2}
11+
import com.digitalasset.canton.integration.plugins.{
12+
UseCommunityReferenceBlockSequencer,
13+
UseH2,
14+
UsePostgres,
15+
}
1216
import com.digitalasset.canton.integration.{
1317
CommunityIntegrationTest,
1418
ConfigTransforms,
@@ -112,7 +116,7 @@ class SimpleFunctionalNodesTestH2 extends SimpleFunctionalNodesTest {
112116
registerPlugin(new UseCommunityReferenceBlockSequencer[DbConfig.H2](loggerFactory))
113117
}
114118

115-
//class SimpleFunctionalNodesTestPostgres extends SimpleFunctionalNodesTest {
116-
// registerPlugin(new UsePostgres(loggerFactory))
117-
// registerPlugin(new UseReferenceBlockSequencer[DbConfig.Postgres](loggerFactory))
118-
//}
119+
class SimpleFunctionalNodesTestPostgres extends SimpleFunctionalNodesTest {
120+
registerPlugin(new UsePostgres(loggerFactory))
121+
registerPlugin(new UseCommunityReferenceBlockSequencer[DbConfig.Postgres](loggerFactory))
122+
}

community/app/src/test/scala/com/digitalasset/canton/integration/tests/pruning/SequencerPruningIntegrationTest.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ trait SequencerPruningIntegrationTest extends CommunityIntegrationTest with Shar
119119
}
120120

121121
protected val pruningRegexWithTrafficPurchase =
122-
"""Removed at least ([1-9]\d*) events, at least (\d+) payloads, at least ([1-9]\d*) counter checkpoints"""
122+
"""Removed at least ([1-9]\d*) events, at least (\d+) payloads"""
123123

124124
protected val pruningRegex =
125-
"""Removed at least ([1-9]\d*) events, at least (\d+) payloads, at least ([1-9]\d*) counter checkpoints"""
125+
"""Removed at least ([1-9]\d*) events, at least (\d+) payloads"""
126126

127127
protected val pruningNothing =
128-
"""Removed at least 0 events, at least 0 payloads, at least 0 counter checkpoints"""
128+
"""Removed at least 0 events, at least 0 payloads"""
129129

130130
"prune only removes events up the point where all enabled clients have acknowledgements" in {
131131
implicit env =>

community/app/src/test/scala/com/digitalasset/canton/integration/tests/repair/IgnoreSequencedEventsIntegrationTest.scala

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ import com.digitalasset.canton.sequencing.protocol.{
3737
import com.digitalasset.canton.sequencing.traffic.TrafficReceipt
3838
import com.digitalasset.canton.store.SequencedEventStore.{
3939
LatestUpto,
40-
OrdinarySequencedEvent,
4140
PossiblyIgnoredSequencedEvent,
41+
SequencedEventWithTraceContext,
4242
}
4343
import com.digitalasset.canton.synchronizer.sequencer.errors.SequencerError.InvalidAcknowledgementTimestamp
4444
import com.digitalasset.canton.topology.MediatorGroup.MediatorGroupIndex
@@ -231,7 +231,7 @@ trait IgnoreSequencedEventsIntegrationTest extends CommunityIntegrationTest with
231231
participant1.health.ping(participant1)
232232
}
233233

234-
// TODO(#11834): Ignoring future events is incompatible with the counter based event ignoring/unignoring APIs,
234+
// TODO(#25162): Ignoring future events is incompatible with the counter based event ignoring/unignoring APIs,
235235
// because the future timestamp are unknown unlike the counters. Need to consider and implement
236236
// a new timestamp-based API for the use case of ignoring future events, should it still be necessary.
237237
"insert an empty ignored event, therefore ignore the next ping and then successfully ping again" ignore {
@@ -305,8 +305,7 @@ trait IgnoreSequencedEventsIntegrationTest extends CommunityIntegrationTest with
305305
// Choose DeliverError as type of tampered event, because we don't expect DeliverErrors to be stored
306306
// as part of the previous tests.
307307
val tamperedEvent = DeliverError.create(
308-
lastStoredEvent.counter,
309-
None, // TODO(#11834): Make sure that ignored sequenced events works with previous timestamps
308+
None,
310309
lastStoredEvent.timestamp,
311310
daId,
312311
MessageId.tryCreate("schnitzel"),
@@ -315,7 +314,7 @@ trait IgnoreSequencedEventsIntegrationTest extends CommunityIntegrationTest with
315314
Option.empty[TrafficReceipt],
316315
)
317316
val tracedSignedTamperedEvent =
318-
OrdinarySequencedEvent(lastEvent.copy(content = tamperedEvent))(traceContext)
317+
SequencedEventWithTraceContext(lastEvent.copy(content = tamperedEvent))(traceContext)
319318

320319
// Replace last event by the tamperedEvent
321320
val p1Node = participant1.underlying.value
@@ -504,7 +503,7 @@ trait IgnoreSequencedEventsIntegrationTest extends CommunityIntegrationTest with
504503
participant1.repair.ignore_events(
505504
daId,
506505
lastRequestSequencerCounter,
507-
// TODO(#11834): This ignores the future event, which is incompatible with previous timestamps.
506+
// TODO(#25162): This ignores the future event, which is incompatible with previous timestamps.
508507
// The test work probably because the result message is ignored without prior confirmation request.
509508
// Need to check if that is good enough and if we don't need to extend event ignoring API
510509
// to support ignoring "future" timestamps.

0 commit comments

Comments
 (0)