Skip to content

Commit 2122bfd

Browse files
Move UpgradesCheckSpec back to the daml repo (#22629)
Companion PR: DACH-NY/canton#30210 This test is an integration test for `UpgradeCheckMain`, itself part of the daml repo. It uses dars generated by the daml repo and not visible by the canton repo. This move means that the upgrade check won't be tested in the canton repo, despite most of the check's code being hosted in the canton repo. So I'll open a canton ticket to create a companion unit test that doesn't use dars but LF packages generated using the LF syntax instead. In the meantime, whenever we find a bug in the check, we'll add a non-regression test to the canton repo. I'll port the changes under `canton/...` in this PR to the canton repo.
1 parent d124835 commit 2122bfd

File tree

6 files changed

+300
-319
lines changed

6 files changed

+300
-319
lines changed

sdk/canton/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ da_scala_library(
264264
tags = ["maven_coordinates=com.daml:base-grpc-utils:__VERSION__"],
265265
unused_dependency_checker_mode = "error",
266266
visibility = [
267-
"//canton/community/daml-lf/validation:__subpackages__",
267+
"//daml-assistant/upgrade-check-main:__subpackages__",
268268
"//daml-script:__subpackages__",
269269
"//test-common/canton:__subpackages__",
270270
],
@@ -414,7 +414,7 @@ proto_gen(
414414
"grpc",
415415
],
416416
visibility = [
417-
"//canton/community/daml-lf/validation:__subpackages__",
417+
"//daml-assistant/upgrade-check-main:__subpackages__",
418418
"//daml-script:__subpackages__",
419419
],
420420
)
@@ -437,7 +437,7 @@ da_scala_library(
437437
]
438438
],
439439
tags = ["maven_coordinates=com.daml:community-admin-api:__VERSION__"],
440-
visibility = ["//canton/community/daml-lf/validation:__subpackages__"],
440+
visibility = ["//daml-assistant/upgrade-check-main:__subpackages__"],
441441
)
442442

443443
### community/base ###

sdk/canton/community/daml-lf/parser/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ da_scala_library(
2020
tags = ["maven_coordinates=com.daml:daml-lf-parser:__VERSION__"],
2121
visibility = [
2222
"//canton/community/daml-lf:__subpackages__",
23+
"//daml-assistant/upgrade-check-main:__subpackages__",
2324
],
2425
deps = [
2526
"//canton:scala-utils",

0 commit comments

Comments
 (0)