Merge pull request #295 from digital-asset/python-fix-create-and-exercise

python: Fix Connection.create_and_exercise.

Author: da-tanabe

VERSION

@@ -1 +1 @@
-7.5.13
+7.5.14

pyproject.toml

@@ -3,7 +3,7 @@
 
 [tool.poetry]
 name = "dazl"
-version = "7.5.13"
+version = "7.5.14"
 description = "high-level Ledger API client for Daml ledgers"
 license = "Apache-2.0"
 authors = ["Davin K. Tanabe <davin.tanabe@digitalasset.com>"]

python/dazl/ledger/grpc/codec_aio.py

@@ -139,7 +139,7 @@ async def encode_create_and_exercise_command(
         item_type, _, choice = await self._look_up_choice(template_id, choice_name)
 
         payload_field, payload_pb = await self.encode_value(con(item_type), payload)
-        if payload_pb != "record":
+        if payload_field != "record":
             raise ValueError("unexpected non-record type when constructing payload")
         argument_field, argument_pb = await self.encode_value(choice.arg_binder.type, argument)
         cmd_pb = lapipb.CreateAndExerciseCommand(

python/tests/unit/test_connection_command_submission.py

@@ -42,3 +42,37 @@ async def test_exercise_by_key(sandbox):
         )
 
         logging.info("Choice result: %r", result.result)
+
+
+@pytest.mark.asyncio
+async def test_create_and_exercise(sandbox):
+    async with connect_with_new_party(url=sandbox, dar=KitchenSink) as p:
+        result = await p.connection.create_and_exercise(
+            "KitchenSink.Retailer:Retailer",
+            {
+                "retailer": p.party,
+                "name": "Kitchen Sinks R Us",
+                "website": "kitchensinksrus.local",
+            },
+            "UpdateWebsite",
+            {"newWebsite": "kitchensinksrus.com"},
+        )
+
+        logging.info("Choice result: %r", result.result)
+
+
+@pytest.mark.asyncio
+async def test_create_and_exercise_unit_arg(sandbox):
+    async with connect_with_new_party(url=sandbox, dar=KitchenSink) as p:
+        result = await p.connection.create_and_exercise(
+            "KitchenSink.Retailer:Order",
+            {
+                "customer": p.party,
+                "payment": 0,
+                "retailer": p.party,
+                "expedite": False,
+            },
+            "MarkAsShipped",
+        )
+
+        logging.info("Choice result: %r", result.result)