[ci] backport of Fix for domainId getting truncated in http response. (#2774) (#2795)

Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>

Author: ray-roestenburg-da

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/admin/http/ScanHttpEncodings.scala

@@ -24,7 +24,7 @@ import org.lfdecentralizedtrust.splice.scan.store.db.DbScanVerdictStore.{
 }
 import org.lfdecentralizedtrust.splice.store.TreeUpdateWithMigrationId
 import org.lfdecentralizedtrust.splice.store.UpdateHistory.UpdateHistoryResponse
-import org.lfdecentralizedtrust.splice.util.{Contract, EventId, LegacyOffset, Trees}
+import org.lfdecentralizedtrust.splice.util.{Codec, Contract, EventId, LegacyOffset, Trees}
 
 import java.time.format.DateTimeFormatterBuilder
 import java.time.{Instant, ZoneOffset}
@@ -460,7 +460,6 @@ object ScanHttpEncodings {
       views.sortBy(_.viewId).toVector.map { v =>
         val quorums: Vector[definitions.Quorum] = v.confirmingParties.asArray
           .getOrElse(Vector.empty)
-          .toVector
           .flatMap { j =>
             val parties = j.hcursor.downField("parties").as[Vector[String]].getOrElse(Vector.empty)
             val threshold = j.hcursor.downField("threshold").as[Int].getOrElse(0)
@@ -482,7 +481,7 @@ object ScanHttpEncodings {
     httpApi.EventHistoryVerdict(
       updateId = verdict.updateId,
       migrationId = verdict.migrationId,
-      domainId = verdict.domainId.toString(),
+      domainId = Codec.encode(verdict.domainId),
       recordTime = formatRecordTime(verdict.recordTime.toInstant),
       finalizationTime = formatRecordTime(verdict.finalizationTime.toInstant),
       submittingParties = verdict.submittingParties.toVector,

apps/scan/src/test/scala/org/lfdecentralizedtrust/splice/scan/admin/http/ScanHttpEncodingsTest.scala

@@ -387,11 +387,13 @@ class ScanHttpEncodingsTest extends StoreTest with TestEssentials with Matchers
     val partyA = mkPartyId("Alice").toProtoPrimitive
     val partyB = mkPartyId("Bob").toProtoPrimitive
     val partyC = mkPartyId("Charlie").toProtoPrimitive
-
+    val dummyDomainLongString =
+      "global-domain::122015405b2293753a19749682fce0c2a6bb6bf03bcd7d9bde2cd0dce9e426c9a2df"
+    val dummyDomainLong = SynchronizerId.tryFromString(dummyDomainLongString)
     val verdictBase = DbScanVerdictStore.VerdictT(
       rowId = 0L,
       migrationId = 3L,
-      domainId = dummyDomain,
+      domainId = dummyDomainLong,
       recordTime = recordTs,
       finalizationTime = recordTs,
       submittingParticipantUid = mkParticipantId("participant").toProtoPrimitive,
@@ -505,7 +507,7 @@ class ScanHttpEncodingsTest extends StoreTest with TestEssentials with Matchers
 
     encodedVerdict.updateId shouldBe verdictBase.updateId
     encodedVerdict.migrationId shouldBe verdictBase.migrationId
-    encodedVerdict.domainId shouldBe dummyDomain.toString
+    encodedVerdict.domainId shouldBe dummyDomainLongString
     encodedVerdict.recordTime should haveMicrosecondPrecision
     encodedVerdict.finalizationTime should haveMicrosecondPrecision
     encodedVerdict.submittingParties shouldBe verdictBase.submittingParties.toVector