Pass image data directly to barcode detector.

dlongley · dlongley · commit 5ec70190f03e · 2025-04-03T20:52:56.000-04:00
diff --git a/lib/barcodes.js b/lib/barcodes.js
@@ -49,10 +49,9 @@ async function _detectWithHspLuminance({barcodeDetector, video}) {
       data[i], data[i + 1], data[i + 2]);
     data[i] = data[i + 1] = data[i + 2] = luminance;
   }
-  ctx.putImageData(imageData, 0, 0);
 
-  // try to detect barcode in updated image
-  return barcodeDetector.detect(canvas);
+  // try to detect barcode in image data
+  return barcodeDetector.detect(imageData);
 }
 
 // HSP = hue, saturation, and "perceived brightness" -- a potential improvement

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,9 @@ async function _detectWithHspLuminance({barcodeDetector, video}) {`
`49`	`49`	`data[i], data[i + 1], data[i + 2]);`
`50`	`50`	`data[i] = data[i + 1] = data[i + 2] = luminance;`
`51`	`51`	`}`
`52`		`- ctx.putImageData(imageData, 0, 0);`
`53`	`52`
`54`		`- // try to detect barcode in updated image`
`55`		`- return barcodeDetector.detect(canvas);`
	`53`	`+ // try to detect barcode in image data`
	`54`	`+ return barcodeDetector.detect(imageData);`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`// HSP = hue, saturation, and "perceived brightness" -- a potential improvement`