Timesheet default view mode wrong depending on screen

[er-vin]

For some reason it looks like window.screen.width and window.screen.height aren't trustworthy enough to pick the default value for the timesheet view mode.

Typically right now it reports for me 1280x720 on a screen which is in fact 2560x1440. Due to this it thinks the height is less than 768 and wrongly picks the split weeks mode. Another solution probably needs to be use to decide which default to pick.

My proposal would be to use the orientation media query. Indeed, if you are in landscape you probably want to favor horizontal layout and have the month mode, if you are in portrait you probably want to favor vertical layout and have the split weeks mode.

This could be achieved using something like the following:

let isPortrait = window.matchMedia("(orientation: portrait)").matches 

[er-vin]

Note that on second though and after discussing it with @abessette it's not clear if the orientation can really be trusted either. This will require testing.

In any case there is an issue in the way the user preference is stored. For instance let's say it picks the week default view mode because of confused width. If I then force it to use the month layout, the information isn't stored anywhere, if I quit my browser and come back I have to force it again. At least is should remember what I picked last in my current browser.

[digitalfox]

information is stored in a cookie named timesheetViewUserPreference, but it's indeed a session cookie for now. The main issue is still to find the good default with reliable heuristic.