Make migrations optional in deployment configuration #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Copilot wants to merge 2 commits into master from copilot/allow-deploy-without-migration

Guide/deployment.markdown

-Original file line number
+Diff line change
@@ Expand Up @@
                 services.ihp = {
                     domain = "myihpapp.com";
-                    migrations = ./Application/Migration;
+                    migrations = ./Application/Migration; # Optional: Remove this line or set to null if you don't use migrations
                     schema = ./Application/Schema.sql;
                     fixtures = ./Application/Fixtures.sql;
                     sessionSecret = "xxx";
@@ Expand Down Expand Up @@
     +
     +                        services.ihp = {
     +                            domain = "myihpapp.com";
-    +                            migrations = ./Application/Migration;
+    +                            migrations = ./Application/Migration; # Optional: Remove this line or set to null if you don't use migrations
     +                            schema = ./Application/Schema.sql;
     +                            fixtures = ./Application/Fixtures.sql;
     +                            sessionSecret = "xxx";
@@ Expand Down @@

NixSupport/nixosModules/options.nix

-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,11 @@ with lib; @@
             };
             migrations = mkOption {
-                type = types.path;
+                type = types.nullOr types.path;
+                default = null;
+                description = ''
+                    Path to the migrations directory. If null, migrations will be skipped.
+                '';
             };
             schema = mkOption {
@@ Expand Down @@

NixSupport/nixosModules/services/migrate.nix

-Original file line number
+Diff line change
@@ -1,8 +1,8 @@
-    { config, pkgs, ihp, ... }:
+    { config, pkgs, lib, ihp, ... }:
     let cfg = config.services.ihp;
     in
     {
-        systemd.services.migrate = {
+        systemd.services.migrate = lib.mkIf (cfg.migrations != null) {
             serviceConfig = {
                 Type = "oneshot";
                 ExecStart = ihp.apps."${pkgs.system}".migrate.program;
@@ Expand Down @@

flake-module.nix

-Original file line number
+Diff line change
@@ Expand Up / @@ -387,7 +387,11 @@ ihpFlake: @@
                             --option sandbox false \
                             --option extra-substituters "https://digitallyinduced.cachix.org" \
                             --option extra-trusted-public-keys "digitallyinduced.cachix.org-1:y+wQvrnxQ+PdEsCt91rmvv39qRCYzEgGQaldK26hCKE="
-                        ssh $1 systemctl start migrate
+                        # Only start migrate service if it exists
+                        if ssh $1 systemctl list-unit-files migrate.service >/dev/null 2>&1; then
+                            ssh $1 systemctl start migrate
+                        fi
                     '';
                     overlays = [ihp.overlays.default];
@@ Expand Down @@

Provide feedback