Merge pull request #20 from digitalutsc/feat/update-to-reusable-workflow-and-lint-codebase

feat: update to reusable CI and lint the codebase

Author: kylehuynh205

.github/workflows/ci.yml

@@ -8,33 +8,8 @@ on:
   workflow_dispatch:
 
 jobs:
-  build:
-    runs-on: ubuntu-latest
-    continue-on-error: false
-    strategy:
-      fail-fast: false
-      matrix:
-        php-versions: ["8.3", "8.4"]
-        drupal-version: ["10.6", "11.3"] 
-
-    name: PHP ${{ matrix.php-versions }} | Drupal ${{ matrix.drupal-version }}
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v5
-
-      - name: Create docker network
-        run: docker network create ci-default
-
-      - name: PHPUnit tests
-        run: |
-          docker run \
-            --rm \
-            --name drupal \
-            --hostname drupal \
-            --volume $(pwd):/var/www/drupal/web/modules/contrib/$ENABLE_MODULES:ro \
-            --env ENABLE_MODULES \
-            --network ci-default \
-           ghcr.io/islandora/ci:${{ matrix.drupal-version }}-php${{ matrix.php-versions }}
-        env:
-          ENABLE_MODULES: islandora_breadcrumbs
+  islandora-module-ci:
+    uses: digitalutsc/reusable_workflows/.github/workflows/islandora-module-ci.yml@main
+    with:
+      module_name: islandora_breadcrumbs
+      install_chromedriver: false

src/IslandoraBreadcrumbBuilder.php

@@ -110,6 +110,7 @@ public function build(RouteMatchInterface $route_match) {
     elseif (isset($parameters['view_id'])) {
       $path = \Drupal::service('path.current')->getPath();
       $url_object = \Drupal::service('path.validator')->getUrlIfValid($path);
+      // phpcs:ignore -- Unused variable $route_name.
       $route_name = $url_object->getRouteName();
       $title = '';
       $path_elements = explode('/', $path);
@@ -138,8 +139,9 @@ public function build(RouteMatchInterface $route_match) {
       }
       else {
         $this->setReferenceBreadcrumbs($breadcrumb, $node);
-        $breadcrumb->addLink(Link::createFromRoute($title, 'entity.node.canonical', ['node' => $nid]));    //updated for breadcrumb issue  
-        }
+        // Updated for breadcrumb issue.
+        $breadcrumb->addLink(Link::createFromRoute($title, 'entity.node.canonical', ['node' => $nid]));
+      }
     }
     else {
       global $_islandora_breadcrumbs_isIslandora;