Skip to content

Commit 1ad9cd8

Browse files
committed
refactor: remove unused variable, improve doc comment
1 parent fc44c88 commit 1ad9cd8

3 files changed

Lines changed: 5 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ jobs:
1212
uses: digitalutsc/reusable_workflows/.github/workflows/islandora-module-ci.yml@main
1313
with:
1414
module_name: islandora_iiif
15-
install_chromedriver: false
15+
install_chromedriver: false

islandora_iiif.info.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ description: 'IIIF support for Islandora'
44
core_version_requirement: ^9 || ^10 || ^11
55
package: Islandora
66
dependencies:
7-
- islandora_lite:termwithuri_condition
7+
- islandora_lite:termwithuri_condition

src/Plugin/views/style/IIIFManifest.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,7 @@ protected function getTileSourceFromRow(ResultRow $row, $iiif_address, $iiif_bas
290290
if (isset($entity->{$viewsField->definition['field_name']})) {
291291
/** @var \Drupal\Core\Field\FieldItemListInterface $images */
292292
$images = $entity->{$viewsField->definition['field_name']};
293-
// phpcs:ignore -- Unused variable $i.
294-
foreach ($images as $i => $image) {
293+
foreach ($images as $image) {
295294
if (!$image->entity->access('view')) {
296295
// If the user does not have permission to view the file, skip it.
297296
continue;
@@ -491,14 +490,10 @@ protected function getOcrUrl(EntityInterface $entity, int $id) {
491490
/**
492491
* Gets nodes that a media belongs to.
493492
*
494-
* // phpcs:ignore -- Doc comment for parameter $media does not match actual variable name $id
495-
* @param \Drupal\media\MediaInterface $media
496-
* The Media whose node you are searching for.
493+
* @param \Drupal\Core\Entity\EntityInterface $entity
494+
* The entity.
497495
* @param int $id
498496
* The ID of the book node.
499-
* // phpcs:ignore -- Doc comment for parameter $entity does not match actual variable name <undefined>
500-
* @param EntityInterface $entity
501-
* The entity.
502497
*
503498
* @return \Drupal\node\NodeInterface
504499
* Parent node.

0 commit comments

Comments
 (0)