Skip to content

Commit 485089f

Browse files
hbulenshbulens
authored
Shorter method names in (I)EmailComposer (#19)
* Remove Set prefix from IEmailComposer methods * Update readme * Bump example packages
1 parent a7dc0b5 commit 485089f

File tree

28 files changed

+185
-854
lines changed

28 files changed

+185
-854
lines changed

‎assets/letter.png‎

-39.7 KB
Binary file not shown.

‎assets/letter.svg‎

Lines changed: 0 additions & 712 deletions
This file was deleted.

‎examples/gmail/Facteur.Examples.Gmail.csproj‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Facteur" Version="2.0.0-beta.2" />
11-
<PackageReference Include="Facteur.Compilers.Scriban" Version="2.0.0-beta.2" />
12-
<PackageReference Include="Facteur.Resolvers.ViewModel" Version="2.0.0-beta.2" />
13-
<PackageReference Include="Facteur.Smtp" Version="2.0.0-beta.2" />
14-
<PackageReference Include="Facteur.TemplateProviders.IO" Version="2.0.0-beta.2" />
10+
<PackageReference Include="Facteur" Version="2.0.0" />
11+
<PackageReference Include="Facteur.Compilers.Scriban" Version="2.0.0" />
12+
<PackageReference Include="Facteur.Resolvers.ViewModel" Version="2.0.0" />
13+
<PackageReference Include="Facteur.Smtp" Version="2.0.0" />
14+
<PackageReference Include="Facteur.TemplateProviders.IO" Version="2.0.0" />
1515
</ItemGroup>
1616

1717
<ItemGroup>

‎src/Facteur.Attachments.IO/Facteur.Attachments.IO.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<PackageLicenseExpression>MIT</PackageLicenseExpression>
2121
<Description>Add attachments using simple IO</Description>
2222
<PackageTags>Facteur;Email;Mail;RazorEngine;Scriban;SendGrid;Graph;SMTP</PackageTags>
23-
<Version>2.0.0</Version>
23+
<Version>2.1.0</Version>
2424
<PackageReadmeFile>README.md</PackageReadmeFile>
2525
</PropertyGroup>
2626
<ItemGroup>

‎src/Facteur.Attachments.IO/README.md‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,13 @@ public async Task SendConfirmationMail(string customerMail, string customerName)
7878
new AppDirectoryTemplateProvider("Templates", ".sbnhtml"),
7979
new ViewModelTemplateResolver());
8080

81-
EmailRequest request = await composer
82-
.SetModel(new TestMailModel { Email = customerMail, Name = customerMail })
83-
.SetSubject("Hello world")
84-
.SetFrom("info@facteur.com")
85-
.SetTo("guy.gadbois@facteur.com")
86-
.SetCc("jacques.clouseau@facteur.com")
87-
.SetBcc("charles.dreyfus@facteur.com")
88-
.Build();
81+
EmailRequest request = await composer
82+
.Subject("Hello world")
83+
.From("info@facteur.com")
84+
.To("guy.gadbois@facteur.com")
85+
.Cc("jacques.clouseau@facteur.com")
86+
.Bcc("charles.dreyfus@facteur.com")
87+
.Build(new TestMailModel { Email = customerMail, Name = customerMail });
8988

9089
EmailRequest populatedRequest = await builder.BuildAsync(request);
9190

‎src/Facteur.Compilers.Scriban/Facteur.Compilers.Scriban.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<Description>Create email bodies using the Scriban template engine.</Description>
1515
<PackageTags>Facteur;Email;Mail;Scriban</PackageTags>
1616
<PackageIconUrl>https://raw.githubusercontent.com/dimesoftware/facteur/master/assets/facteur.png?raw=true</PackageIconUrl>
17-
<Version>2.0.0</Version>
17+
<Version>2.1.0</Version>
1818
<Authors>Dime Software</Authors>
1919
<Company>Dime Software</Company>
2020
<Product>Facteur</Product>

‎src/Facteur.Compilers.Scriban/README.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ public async Task SendConfirmationMail(string customerMail, string customerName)
7979
new ViewModelTemplateResolver());
8080

8181
EmailRequest request = await composer
82-
.SetSubject("Hello world")
83-
.SetFrom("info@facteur.com")
84-
.SetTo("guy.gadbois@facteur.com")
85-
.SetCc("jacques.clouseau@facteur.com")
86-
.SetBcc("charles.dreyfus@facteur.com")
82+
.Subject("Hello world")
83+
.From("info@facteur.com")
84+
.To("guy.gadbois@facteur.com")
85+
.Cc("jacques.clouseau@facteur.com")
86+
.Bcc("charles.dreyfus@facteur.com")
8787
.BuildAsync(new TestMailModel { Email = customerMail, Name = customerMail });
8888

8989
SmtpCredentials credentials = new("smtp.gmail.com", "587", "false", "true", "myuser@gmail.com", "mypassword");
@@ -98,11 +98,11 @@ If you use DI, you can just use `IMailer` and use the overload that exposes the
9898
public async Task SendConfirmationMail(string customerMail, string customerName)
9999
{
100100
await mailer.SendMailAsync(x => x
101-
.SetSubject("Hello world")
102-
.SetFrom("info@facteur.com")
103-
.SetTo("guy.gadbois@facteur.com")
104-
.SetCc("jacques.clouseau@facteur.com")
105-
.SetBcc("charles.dreyfus@facteur.com")
101+
.Subject("Hello world")
102+
.From("info@facteur.com")
103+
.To("guy.gadbois@facteur.com")
104+
.Cc("jacques.clouseau@facteur.com")
105+
.Bcc("charles.dreyfus@facteur.com")
106106
.BuildAsync(new TestMailModel { Email = customerMail, Name = customerMail }));
107107
}
108108
```

‎src/Facteur.Extensions.DependencyInjection.Tests/ServiceCollectionTests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ public async Task ServiceCollection_Defaults_ShouldConstructAndSendMail()
3434
ServiceProvider serviceProvider = serviceCollection.BuildServiceProvider();
3535
IMailer mailer = serviceProvider.GetService<IMailer>();
3636
//await mailer.SendMailAsync(x => x
37-
//.SetSubject("Hello world")
38-
//.SetFrom("info@facteur.com")
39-
//.SetTo("byziji2958@chapsmail.com")
37+
//.Subject("Hello world")
38+
//.From("info@facteur.com")
39+
//.To("byziji2958@chapsmail.com")
4040
//.BuildAsync(new TestMailModel { Email = "guy.gadbois@facteur.com", Name = "Guy Gadbois" }));
4141
}
4242

‎src/Facteur.Extensions.DependencyInjection/Facteur.Extensions.DependencyInjection.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1414
<PackageTags>Facteur;Email;Mail;RazorEngine;Scriban;SendGrid;Graph;SMTP</PackageTags>
1515
<Description>ASP.NET Core extensions for facteur.</Description>
16-
<Version>2.0.0</Version>
16+
<Version>2.1.0</Version>
1717
<Authors>Dime Software</Authors>
1818
<Company>Dime Software</Company>
1919
<Product>Facteur</Product>

‎src/Facteur.Extensions.DependencyInjection/README.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ public async Task SendConfirmationMail(string customerMail, string customerName)
8080
new ViewModelTemplateResolver());
8181

8282
EmailRequest request = await composer
83-
.SetSubject("Hello world")
84-
.SetFrom("info@facteur.com")
85-
.SetTo("guy.gadbois@facteur.com")
86-
.SetCc("jacques.clouseau@facteur.com")
87-
.SetBcc("charles.dreyfus@facteur.com")
83+
.Subject("Hello world")
84+
.From("info@facteur.com")
85+
.To("guy.gadbois@facteur.com")
86+
.Cc("jacques.clouseau@facteur.com")
87+
.Bcc("charles.dreyfus@facteur.com")
8888
.BuildAsync(new TestMailModel { Email = customerMail, Name = customerMail });
8989

9090
SmtpCredentials credentials = new("smtp.gmail.com", "587", "false", "true", "myuser@gmail.com", "mypassword");
@@ -99,11 +99,11 @@ If you use DI, you can just use `IMailer` and use the overload that exposes the
9999
public async Task SendConfirmationMail(string customerMail, string customerName)
100100
{
101101
await mailer.SendMailAsync(x => x
102-
.SetSubject("Hello world")
103-
.SetFrom("info@facteur.com")
104-
.SetTo("guy.gadbois@facteur.com")
105-
.SetCc("jacques.clouseau@facteur.com")
106-
.SetBcc("charles.dreyfus@facteur.com")
102+
.Subject("Hello world")
103+
.From("info@facteur.com")
104+
.To("guy.gadbois@facteur.com")
105+
.Cc("jacques.clouseau@facteur.com")
106+
.Bcc("charles.dreyfus@facteur.com")
107107
.BuildAsync(new TestMailModel { Email = customerMail, Name = customerMail }));
108108
}
109109
```

0 commit comments

Comments
 (0)