Skip to content

Comparison methods panic for differently sized matrices #1572

@PaulXiCao

Description

@PaulXiCao

Wouldn't it make more sense to return false? It's not obvious to me that comparing dynamically-sized matrices of different size is necessarily a bug.

Originally posted by @Ralith in #1568 (comment)

The methods in question that assert!(self.shape() == other.shape()):

Matrix::relative_eq()
Matrix::eq()
Matrix::abs_diff_eq()
Matrix::ulps_eq()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions