Create constructor for ConvexPolyline that does not remove any vertices #278
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ughuuu
force-pushed
the
create-constructor-that-does-not-remove-points
branch
from
ffc7300
to
4eb05f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Godot Rapier, Godot sends vertices that it uses to draw the polygon. If Parry removes some vertices, then the physics will not work correct. We need the extra vertices even if collinear, and ideally have the collinearity check done in Godot at some point or sent as a warning to console. For now a function that accepts points and doesn't remove any is needed for this use case.