Transpiler doesn't cd into puzzle directory to build

[int00h5525]

Description

In v3, the dev server cd'ed into a puzzle/category's directory so that any puzzle definitions could refer to local paths. In v4, we have to introduce hacks to determine the path to a local file

Steps to Reproduce

1. Create a puzzle which refers to a local file (/puzzles/foo/1/mkpuzzle, in Python; open("foo.txt", "r"), and file /puzzles/foo/1/foo.txt)
2. From /, run transpile puzzle -dir /puzzles/foo/1/

Expected behavior:

mkpuzzle loads local file foo.txt from /puzzles/foo/1/foo.txt

Actual behavior:

mkpuzzle attempt to load file foo.txt from /foo.txt

Reproduces how often:

100%

Versions

v4

[nealey]

I can't figure out how reproduce this, either from unit tests or from the commandline. Are you sure you're using a build from the main branch?

[int00h5525]

It looks like this may only happen with mkcategory execution. Try loading any of the example puzzles which contain other files as attachments and loading them with the example mkcategory script (modified for general case execution).

It also looks like the transpiler is trying to run mkpuzzle file puzzle.json which won't work.

root@39ff40fafc04:/# mothd -puzzles /tmp/puzzles/
2020/11/02 17:23:04 Listening on :8080
2020/11/02 17:23:06 192.168.200.134:51400 GET /puzzle.html?cat=test&points=1 304
2020/11/02 17:23:06 192.168.200.134:51400 GET /content/test/1/puzzle.json 200
2020/11/02 17:23:06 192.168.200.134:51400 GET /content/test/1/salad.jpg 404
^C
root@39ff40fafc04:/# cat /tmp/log
Running command ['./mkpuzzle', 'puzzle'] from path ['/tmp/puzzles/test/test2/1', '/usr/local/lib/python38.zip', '/usr/local/lib/python3.8', '/usr/local/lib/python3.8/lib-dynload', '/usr/local/lib/python3.8/site-packages']
Running command ['./mkpuzzle', 'file', 'puzzle.json'] from path ['/tmp/puzzles/test/test2/1', '/usr/local/lib/python38.zip', '/usr/local/lib/python3.8', '/usr/local/lib/python3.8/lib-dynload', '/usr/local/lib/python3.8/site-packages']

puzzle.tar.gz

[nealey]

At this point I don't have any idea what you think the problem is. Try adding pwd > /tmp/154.pwd to line 2 of your mkcategory and load the puzzle again. Afterwards, the file /tmp/154.pwd will contain /tmp/puzzles/test, which seems to be the exact behavior you are saying doesn't exist (but should).

If you're trying to get the transpiler to run mkcategory, I recommend you instead get your mkcategory to run mkcategory. The only mechanism the transpiler currently exposes for generating an entire category's worth of puzzle is mothball.

[int00h5525]

This happens with any embedded category using a mkcategory-like mechanism in which puzzles contain attachments. As another demonstration, using only the example puzzles provided in this repo, copy example/2 (containing the salad images) into mkcategory/subcat1/4. Both the mothball command and mothd fail to correctly handle this.

Transpile mothball

Expected

root@4ccbfc9acc2d:/# transpile mothball -dir /puzzles/example/ -out /tmp/example.mb
2020/11/02 22:45:09 Writing mothball to /tmp/example.mb
root@4ccbfc9acc2d:/# ls -l /tmp/
total 64
-rw-r--r--. 1 root root 64052 Nov  2 22:45 example.mb
root@4ccbfc9acc2d:/#

Actual

root@4ccbfc9acc2d:/# transpile mothball -dir /puzzles/mkcategory/ -out /tmp/mkcategory.mb
2020/11/02 22:40:37 Writing mothball to /tmp/mkcategory.mb
2020/11/02 22:40:37 Puzzle 4: salad.jpg: exit status 1: 2020/11/02 22:40:37 Not listed in attachments or scripts: puzzle.json
root@4ccbfc9acc2d:/# ls -l /tmp/
total 0
root@4ccbfc9acc2d:/#

Run mothd

Expected

root@4ccbfc9acc2d:/# mothd -puzzles /puzzles/
2020/11/02 22:43:06 Listening on :8080
2020/11/02 22:43:20 192.168.200.134:58191 GET /puzzle.html?cat=example&points=2 200
2020/11/02 22:43:20 192.168.200.134:58191 GET /content/example/2/puzzle.json 200
2020/11/02 22:43:20 192.168.200.134:58191 GET /content/example/2/salad.jpg 200
2020/11/02 22:43:20 192.168.200.134:58192 GET /content/example/2/s2.jpg 200

Actual

root@4ccbfc9acc2d:/# mothd -puzzles /puzzles/
2020/11/02 22:42:04 Listening on :8080
2020/11/02 22:42:05 192.168.200.134:58105 GET /state?id=1&pid=rodney 200
2020/11/02 22:42:06 192.168.200.134:58105 GET /content/mkcategory/4/puzzle.json 200
2020/11/02 22:42:06 192.168.200.134:58105 GET /content/mkcategory/4/salad.jpg 404
2020/11/02 22:42:06 192.168.200.134:58106 GET /content/mkcategory/4/s2.jpg 404

[nealey]

Okay, my understanding now is that the bug is with mkcategory in the example-puzzles directory. Does that sound right?

…

On Mon, Nov 2, 2020, 15:47 int00h5525 ***@***.***> wrote: This happens with any embedded category using a mkcategory-like mechanism in which puzzles contain attachments. As another demonstration, using only the example puzzles provided in this repo, copy example/2 (containing the salad images) into mkcategory/subcat1/4. Both the mothball command and mothd fail to correctly handle this. Transpile mothball Expected ***@***.***:/# transpile mothball -dir /puzzles/example/ -out /tmp/example.mb 2020/11/02 22:45:09 Writing mothball to /tmp/example.mb ***@***.***:/# ls -l /tmp/ total 64 -rw-r--r--. 1 root root 64052 Nov 2 22:45 example.mb ***@***.***:/# Actual ***@***.***:/# transpile mothball -dir /puzzles/mkcategory/ -out /tmp/mkcategory.mb 2020/11/02 22:40:37 Writing mothball to /tmp/mkcategory.mb 2020/11/02 22:40:37 Puzzle 4: salad.jpg: exit status 1: 2020/11/02 22:40:37 Not listed in attachments or scripts: puzzle.json ***@***.***:/# ls -l /tmp/ total 0 ***@***.***:/# Run mothd Expected ***@***.***:/# mothd -puzzles /puzzles/ 2020/11/02 22:43:06 Listening on :8080 2020/11/02 22:43:20 192.168.200.134:58191 GET /puzzle.html?cat=example&points=2 200 2020/11/02 22:43:20 192.168.200.134:58191 GET /content/example/2/puzzle.json 200 2020/11/02 22:43:20 192.168.200.134:58191 GET /content/example/2/salad.jpg 200 2020/11/02 22:43:20 192.168.200.134:58192 GET /content/example/2/s2.jpg 200 [image: image] <https://user-images.githubusercontent.com/38926894/97927438-958fe700-1d2a-11eb-8bbc-3d0f80cedef7.png> Actual ***@***.***:/# mothd -puzzles /puzzles/ 2020/11/02 22:42:04 Listening on :8080 2020/11/02 22:42:05 192.168.200.134:58105 GET /state?id=1&pid=rodney 200 2020/11/02 22:42:06 192.168.200.134:58105 GET /content/mkcategory/4/puzzle.json 200 2020/11/02 22:42:06 192.168.200.134:58105 GET /content/mkcategory/4/salad.jpg 404 2020/11/02 22:42:06 192.168.200.134:58106 GET /content/mkcategory/4/s2.jpg 404 [image: image] <https://user-images.githubusercontent.com/38926894/97927341-709b7400-1d2a-11eb-91f2-71f48e0af78d.png> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADHOZEPHIHLBSQHFMFOWLDSN4ZGNANCNFSM4TFIG7YQ> .

[int00h5525]

Potentially. I'm testing against my Python implementation of mkcategory to weed that part out.

[nealey]

Okay, this seems to trigger a problem:

cd example-puzzles/mkcategory
cp -r ../example/2 30
./mkcategory file 30 salad.jpg
2020/11/02 16:05:36 Not listed in attachments or scripts: puzzle.json

[nealey]

For that matter, transpile file doesn't appear to work with any mkpuzzle directory.

I'm not sure if this is the bug you were reporting, though, @int00h5525...

[nealey]

It appears the bug is exactly the opposite of the subject: the transpiler can't cope if it's invoked from the directory containing the puzzle!

[int00h5525]

Below are some logs that I generated by tracing my Python-based implementation of mkcategory

Command args are ['./mkcategory', 'inventory']
Command args are ['./mkcategory', 'puzzle', '1']
Command args are ['./mkcategory', 'puzzle', '2']
Command args are ['./mkcategory', 'file', '2', 'salad.jpg']
Tried to open salad.jpg, status: 1 (0==good, 1==fail)
path while opening file is ['/puzzles/mkcategory', '/usr/local/lib/python38.zip', '/usr/local/lib/python3.8', '/usr/local/lib/python3.8/lib-dynload', '/usr/local/lib/python3.8/site-packages']
Puzzle files: {}
Command args are ['./mkcategory', 'file', '2', 's2.jpg']
Tried to open s2.jpg, status: 1 (0==good, 1==fail)
path while opening file is ['/puzzles/mkcategory', '/usr/local/lib/python38.zip', '/usr/local/lib/python3.8', '/usr/local/lib/python3.8/lib-dynload', '/usr/local/lib/python3.8/site-packages']
Puzzle files: {}
Command args are ['./mkcategory', 'puzzle', '3']