Replace neovisionaries websocket library

[MinnDevelopment]

General Troubleshooting

• I have checked for similar issues on the Issue-tracker.
• I have updated to the latest JDA version
• I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request

The WebSocket client library used by JDA is no longer being maintained. We should consider replacing it with a maintained alternative. This requires some major refactoring, but is necessary for the continued security, maintainability, and efficiency of the library.

When we replace the library, we should also consider making the gateway implementation more testable.

Example Use-Case

N/A

[Andre601]

Are there already some candidates for replacing the library, or is this still something to look for?

[MinnDevelopment]

I have not looked into alternatives yet, I just wanted to have this on my backlog.

[Horstexplorer]

I would like to suggest considering a Jakarta EE 10/11 compatible solution, such as the Jetty WebSocket Client. While Jetty is unlikely to become unmaintained in the foreseeable future, in my experience, JEE tends to enable rather smooth transitions between implementations aswell as major versions.
Unfortunately, this approach would likely require upgrading the JRE version as well.

Using the WebSocket capabilities of OkHttp could be another option, but version 4 appears to no longer be actively developed, and progress on version 5 is moving rather slowly.

[Goldmensch]

In my opinion, it’s the best to bump jdk to 17 and use jetty. No bot that uses java 8 does update their jda dependency on a regular basis. And if so still, bumping java is as easy as that too. There’s no need to stick to an old java version and search for a library supporting that outdated jdk.

[Almighty-Satan]

We have quite a few users that are stuck on Java 8 due to software that we have no control over. JDA moving to a newer Java version would mean that we would eventually have to replace JDA with another library that still supports Java 8. I'd suggest using reactor-netty (https://github.com/reactor/reactor-netty) as it's actively being maintained and supports Java 8.

[SerenModz21]

We have quite a few users that are stuck on Java 8 due to software that we have no control over.

Couldn't those users utilise containerization via Docker or Podman? That would allow keeping the Java 8 software running on that version, while JDA bots run on modern Java.

[derklaro]

I know this thread is a bit older, but I wanted to suggest the websocket implementation added in jdk11 together with the new http client. Maybe it's worth a try, but requires a jdk version bump as well

[dima-dencep]

@derklaro The ws implementation in Java11 is single-threaded, which can cause issues

[freya022]

In which ways should the WS be more testable?

Also +1 for okhttp WebSockets, so we don't need another dependency, can stay Java 8 compatible and have the same settings for both HTTP and WS

[dima-dencep]

I would prefer Netty WebSocket over OkHttp WS, and Java 8 support will remain as well.