fix(voice): strip padding from packets and add guards #13725
Annotations
4 errors and 3 warnings
|
Tests
Process completed with exit code 1.
|
|
Tests
@discordjs/voice#lint: command (/home/runner/work/discord.js/discord.js/packages/voice) /home/runner/setup-pnpm/node_modules/.bin/pnpm run lint --format=compact exited (1)
|
|
Tests:
packages/voice/src/receive/VoiceReceiver.ts#L10
`../util/Secretbox` import should occur before import of `../util/constants`
|
|
Tests:
packages/voice/src/networking/Networking.ts#L11
`../util/Secretbox` import should occur before import of `../util/constants`
|
|
Tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, pnpm/action-setup@v4.1.0. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests:
packages/voice/__tests__/VoiceWebSocket.test.ts#L24
Unexpected 'todo' comment: 'TODO: Fix voice tests'.
|
|
Tests:
packages/voice/__tests__/Secretbox.test.ts#L7
Unexpected 'todo' comment: 'TODO: what is this even testing exactly?'.
|