Skip to content

Commit 0e30897

Browse files
committed
fix: add more tests
1 parent 4baa4af commit 0e30897

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/node-opus.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ NodeOpusEncoder::NodeOpusEncoder(const CallbackInfo& args): ObjectWrap<NodeOpusE
6666
}
6767

6868
this->application = OPUS_APPLICATION_AUDIO;
69-
this->outPcm = new opus_int16[channels * MAX_FRAME_SIZE];
69+
this->outPcm = new opus_int16[this->channels * MAX_FRAME_SIZE];
7070
}
7171

7272
NodeOpusEncoder::~NodeOpusEncoder() {

tests/test.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,21 @@ const { OpusEncoder } = require('../lib/index.js');
1414
const reEncoded = opus.encode(decoded);
1515

1616
assert(decoded.length === 640, 'Decoded frame length is not 640');
17-
assert(reEncoded.length === 45, 're encoded frame length is not 45');
17+
assert(reEncoded.length === 45, 're-encoded frame length is not 45');
1818
}
1919

2020
// Default values work
2121
{
2222
new OpusEncoder();
23+
new OpusEncoder(undefined, undefined);
24+
}
25+
26+
// Invalid values throw
27+
{
28+
assert.throws(() => new OpusEncoder("16000", 1), /Expected rate to be a number/);
29+
assert.throws(() => new OpusEncoder(null, "1"), /Expected rate to be a number/);
30+
assert.throws(() => new OpusEncoder(16000, "1"), /Expected channels to be a number/);
31+
assert.throws(() => new OpusEncoder(16000, null), /Expected channels to be a number/);
2332
}
2433

2534
console.log('Passed');

0 commit comments

Comments
 (0)