DEV: Migrate category expert suggestion to reviewable-refresh (#217)

This migrates ReviewableCategoryExpertSuggestion to use Discourse's new
reviewable-refresh component system:

- Add reviewable-refresh/category-expert-suggestion.gjs component that
  wraps the legacy component in the new structure
- Register the reviewable type label using registerReviewableTypeLabel
- Update system specs to use refreshed review page objects and new CSS
  selectors (.review-item instead of .reviewable-item)

Author: KrisKotlarek

assets/javascripts/discourse/components/reviewable-refresh/category-expert-suggestion.gjs

@@ -0,0 +1,13 @@
+/* eslint-disable ember/no-classic-components */
+import Component from "@ember/component";
+import LegacyCategoryExpertSuggestion from "../reviewable-category-expert-suggestion";
+
+export default class ReviewableLegacyCategoryExpertSuggestion extends Component {
+  <template>
+    <div class="review-item__meta-content">
+      <LegacyCategoryExpertSuggestion @reviewable={{@reviewable}}>
+        {{yield}}
+      </LegacyCategoryExpertSuggestion>
+    </div>
+  </template>
+}

assets/javascripts/discourse/pre-initializers/extend-for-category-experts.js

@@ -1,4 +1,5 @@
 import { and } from "@ember/object/computed";
+import { registerReviewableTypeLabel } from "discourse/components/reviewable-refresh/item";
 import { withPluginApi } from "discourse/lib/plugin-api";
 import Composer from "discourse/models/composer";
 import ExpertGroupChooserModal from "../components/modal/expert-group-chooser";
@@ -19,6 +20,11 @@ export default {
       "is_category_expert_question"
     );
 
+    registerReviewableTypeLabel(
+      "ReviewableCategoryExpertSuggestion",
+      "review.types.reviewable_category_expert_suggestion.title"
+    );
+
     withPluginApi((api) => {
       api.modifyClass(
         "model:category",

spec/system/reviewable_category_expert_suggestion_spec.rb

@@ -6,6 +6,7 @@
   fab!(:category)
   fab!(:group)
   let(:modal) { PageObjects::Modals::Base.new }
+  let(:refreshed_review_page) { PageObjects::Pages::RefreshedReview.new }
 
   before do
     SiteSetting.enable_category_experts = true
@@ -56,11 +57,11 @@
       visit "/review"
 
       reviewable = ReviewableCategoryExpertSuggestion.find_by(target: endorsement)
-      expect(page).to have_css(".reviewable-item[data-reviewable-id=\"#{reviewable.id}\"]")
+      expect(page).to have_css(".review-item[data-reviewable-id=\"#{reviewable.id}\"]")
 
-      find(".reviewable-action", text: /Ignore/).click
-      expect(page).to have_content(I18n.t("js.review.none"), wait: 5)
-      expect(reviewable.reload.status).to eq("rejected")
+      find(".category-expert-endorsement-deny-category-expert", text: /Ignore/).click
+
+      expect(refreshed_review_page).to have_reviewable_with_rejected_status(reviewable)
     end
   end
 end