DEV: Also hide the globe when post is recently updated (#278)

In #229 we added a buffer to not show the 🌐 within 10 seconds of post creation. We need to extend this to post edits as well to allow the edited post to be translated automatically and prevent the user from seeing the flash of 🌐

Author: nattsw

lib/discourse_translator/extensions/guardian_extension.rb

@@ -27,9 +27,9 @@ def can_translate?(post)
         return false if post.user&.bot?
         return false if !user_group_allow_translate?
 
-        # we want to return false if the post is created within a short buffer ago,
+        # we want to return false if the post is updated within a short buffer ago,
         # this prevents the 🌐from appearing and then disappearing if the lang is same as user's lang
-        return false if post.created_at > POST_DETECTION_BUFFER.ago && post.detected_locale.blank?
+        return false if post.updated_at > POST_DETECTION_BUFFER.ago && post.detected_locale.blank?
 
         if SiteSetting.experimental_inline_translation
           locale = DiscourseTranslator::InlineTranslation.effective_locale

spec/lib/guardian_extension_spec.rb

@@ -117,7 +117,7 @@
   describe "#can_translate?" do
     fab!(:group)
     fab!(:user) { Fabricate(:user, locale: "en", groups: [group]) }
-    fab!(:post) { Fabricate(:post, created_at: 5.minutes.ago) }
+    fab!(:post) { Fabricate(:post, updated_at: 5.minutes.ago) }
 
     let(:guardian) { Guardian.new(user) }
 
@@ -160,16 +160,16 @@
         expect(guardian.can_translate?(post)).to eq(false)
       end
 
-      it "allows translation depending on when the post is created" do
+      it "allows translation depending on when the post is updated" do
         SiteSetting.restrict_translation_by_group = "#{group.id}"
 
-        post.update(created_at: Time.now)
+        post.update(updated_at: Time.now)
         expect(guardian.can_translate?(post)).to eq(false)
 
         post.set_detected_locale("jp")
         expect(guardian.can_translate?(post)).to eq(true)
 
-        post.update(created_at: 5.minutes.ago)
+        post.update(updated_at: 5.minutes.ago)
         expect(guardian.can_translate?(post)).to eq(true)
 
         post.set_detected_locale("pt")