Skip to content

Commit 305fe03

Browse files
Close quality and dev workflow checklist (#3)
## Summary - mark Step 2 (Quality Gates & CI) as completed in `todo.md` - mark Step 3 (Dev/Build Workflow Consistency) as completed in `todo.md` - keep the optional `Disable direct push to main` item open for follow-up
2 parents 0815a03 + 1c046a6 commit 305fe03

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

todo.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,35 +23,35 @@ Acceptance:
2323
---
2424

2525
## 2) Quality Gates & CI
26-
- [ ] Verify CI runs: `typecheck`, `vite:build`, `theme-check`
27-
- [ ] Confirm CI runs on `push` + `pull_request`
28-
- [ ] Confirm no regressions in workflow after simplifications
26+
- [x] Verify CI runs: `typecheck`, `vite:build`, `theme-check`
27+
- [x] Confirm CI runs on `push` + `pull_request`
28+
- [x] Confirm no regressions in workflow after simplifications
2929

3030
Step 2 closure checklist:
31-
- [ ] Open a recent PR and confirm both checks are green:
31+
- [x] Open a recent PR and confirm both checks are green:
3232
- `Typecheck and Build`
3333
- `Theme Check`
34-
- [ ] Enable branch protection on `main` and `staging` with required checks:
34+
- [x] Enable branch protection on `main` and `staging` with required checks:
3535
- `Typecheck and Build`
3636
- `Theme Check`
37-
- [ ] Block merge when checks are pending/failing
37+
- [x] Block merge when checks are pending/failing
3838
- [ ] (Optional) Disable direct push to `main`
3939

4040
Acceptance:
41-
- [ ] All checks green on PR
42-
- [ ] Failing checks block merge
41+
- [x] All checks green on PR
42+
- [x] Failing checks block merge
4343

4444
---
4545

4646
## 3) Dev/Build Workflow Consistency
47-
- [ ] Verify `bun run dev` (local) works consistently
48-
- [ ] Verify `bun run dev:remote` works for Shopify-domain preview (tunnel)
49-
- [ ] Verify `bun run build` generates all expected assets and `vite-tag` mappings
50-
- [ ] Confirm team uses full domain in `.env` (`*.myshopify.com`)
47+
- [x] Verify `bun run dev` (local) works consistently
48+
- [x] Verify `bun run dev:remote` works for Shopify-domain preview (tunnel)
49+
- [x] Verify `bun run build` generates all expected assets and `vite-tag` mappings
50+
- [x] Confirm team uses full domain in `.env` (`*.myshopify.com`)
5151

5252
Acceptance:
53-
- [ ] Local + remote preview both reliable
54-
- [ ] No CORS/PNA blockers in normal flow
53+
- [x] Local + remote preview both reliable
54+
- [x] No CORS/PNA blockers in normal flow
5555

5656
---
5757

0 commit comments

Comments
 (0)