Revisit our requirements for the controller name and reconcile the validation code with them

[webbnh]

The recent Greenfield Installation Exercise revealed problems around the current requirements on controller IDs.

Having an EC2:: prefix on the controller causes a series of problems. Aside from the fact that the colons have special meaning in many contexts, pbench-results-push currently requires the controller to be a valid host name (as does the Server PUT API), and colons are not valid characters in that context. And, renaming the tarball and altering the controller argument don't help, since the controller name is stored in the metadata inside the tarball, and the resulting mismatch causes the upload to be quarantined for bad metadata.

For the exercise, we temporarily disabled the validation of the controller name in agent/results.py, and then we did the same in the Server PUT method. Without these changes, we cannot upload EC2 datasets using pbench-results-push.

We need to revisit our requirements for the controller name and reconcile the validation code with them.