Better condition here would be: require(roundIsClosed() == true, "Round is already open"); since the round can be closed by expiration as well.
|
require(roundDuration == 0, "Round is already open"); |
Additionally openRound should take roundDuration as an argument, instead of hardcoding it for 1 month
|
function openRound() public onlyAdmin { |
EDIT: Sorry I just noticed there are 2 functions openRound and startRound, seems like openRound is redundant so you can remove it
Better condition here would be:
require(roundIsClosed() == true, "Round is already open");since the round can be closed by expiration as well.streamtide-smart-contract/streamtide.sol
Line 51 in 5740c35
Additionally
openRoundshould takeroundDurationas an argument, instead of hardcoding it for 1 monthstreamtide-smart-contract/streamtide.sol
Line 50 in 5740c35
EDIT: Sorry I just noticed there are 2 functions
openRoundandstartRound, seems likeopenRoundis redundant so you can remove it