Skip to content

Improvements for openRound #9

Description

@madvas

Better condition here would be: require(roundIsClosed() == true, "Round is already open"); since the round can be closed by expiration as well.

require(roundDuration == 0, "Round is already open");

Additionally openRound should take roundDuration as an argument, instead of hardcoding it for 1 month

function openRound() public onlyAdmin {

EDIT: Sorry I just noticed there are 2 functions openRound and startRound, seems like openRound is redundant so you can remove it

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions