feat: allow dismissing divine login banner on profile

Author: rabble-claw

mobile/lib/widgets/profile/profile_header_widget.dart

@@ -12,6 +12,7 @@ import 'package:openvine/blocs/email_verification/email_verification_cubit.dart'
 import 'package:openvine/blocs/my_profile/my_profile_bloc.dart';
 import 'package:openvine/providers/app_providers.dart';
 import 'package:openvine/providers/nip05_verification_provider.dart';
+import 'package:openvine/providers/shared_preferences_provider.dart';
 import 'package:openvine/providers/user_profile_providers.dart';
 import 'package:openvine/screens/auth/secure_account_screen.dart';
 import 'package:openvine/screens/auth/welcome_screen.dart';
@@ -27,6 +28,9 @@ import 'package:openvine/widgets/user_name.dart';
 
 /// Profile header widget displaying avatar, stats, name, and bio.
 class ProfileHeaderWidget extends ConsumerWidget {
+  static const _dismissedDivineLoginBannerPrefix =
+      'dismissed_divine_login_banner_';
+
   const ProfileHeaderWidget({
     required this.userIdHex,
     required this.isOwnProfile,
@@ -89,6 +93,11 @@ class ProfileHeaderWidget extends ConsumerWidget {
     ref.watch(currentAuthStateProvider);
     final isAnonymous = authService.isAnonymous;
     final hasExpiredSession = authService.hasExpiredOAuthSession;
+    final prefs = ref.watch(sharedPreferencesProvider);
+    final dismissedDivineLoginBannerKey =
+        '$_dismissedDivineLoginBannerPrefix$userIdHex';
+    final isDivineLoginBannerDismissed =
+        prefs.getBool(dismissedDivineLoginBannerKey) ?? false;
 
     // Use profile color as header background (like original Vine)
     // Color covers avatar/stats, then fades to dark for name/bio readability
@@ -128,8 +137,12 @@ class ProfileHeaderWidget extends ConsumerWidget {
 
                 // Session expired banner for divineOAuth users (only on own
                 // profile) — prompts re-login instead of "Secure Your Account"
-                if (isOwnProfile && hasExpiredSession)
-                  const _SessionExpiredBanner()
+                if (isOwnProfile &&
+                    hasExpiredSession &&
+                    !isDivineLoginBannerDismissed)
+                  _SessionExpiredBanner(
+                    dismissedPreferenceKey: dismissedDivineLoginBannerKey,
+                  )
                 // Secure account banner for anonymous users (only on own
                 // profile)
                 else if (isOwnProfile && isAnonymous)
@@ -420,7 +433,9 @@ class _IdentityNotRecoverableBanner extends StatelessWidget {
 /// Prompts the user to sign in again instead of showing "Secure Your Account".
 /// Attempts a silent token refresh first; navigates to login only if that fails.
 class _SessionExpiredBanner extends ConsumerStatefulWidget {
-  const _SessionExpiredBanner();
+  const _SessionExpiredBanner({required this.dismissedPreferenceKey});
+
+  final String dismissedPreferenceKey;
 
   @override
   ConsumerState<_SessionExpiredBanner> createState() =>
@@ -429,6 +444,7 @@ class _SessionExpiredBanner extends ConsumerStatefulWidget {
 
 class _SessionExpiredBannerState extends ConsumerState<_SessionExpiredBanner> {
   bool _isRefreshing = false;
+  bool _isDismissed = false;
 
   Future<void> _onSignIn() async {
     setState(() => _isRefreshing = true);
@@ -444,8 +460,16 @@ class _SessionExpiredBannerState extends ConsumerState<_SessionExpiredBanner> {
     }
   }
 
+  Future<void> _dismissBanner() async {
+    setState(() => _isDismissed = true);
+    final prefs = ref.read(sharedPreferencesProvider);
+    await prefs.setBool(widget.dismissedPreferenceKey, true);
+  }
+
   @override
   Widget build(BuildContext context) {
+    if (_isDismissed) return const SizedBox.shrink();
+
     return Container(
       margin: const EdgeInsets.only(bottom: 16),
       padding: const EdgeInsets.all(16),
@@ -499,6 +523,11 @@ class _SessionExpiredBannerState extends ConsumerState<_SessionExpiredBanner> {
                     ),
                   ),
           ),
+          IconButton(
+            onPressed: _dismissBanner,
+            icon: const Icon(Icons.close, color: VineTheme.whiteText, size: 20),
+            tooltip: 'Dismiss',
+          ),
         ],
       ),
     );

mobile/test/widgets/profile/profile_header_widget_test.dart

@@ -78,9 +78,13 @@ class MockNostrClient extends Mock implements NostrClient {
 }
 
 class MockAuthService extends Mock implements AuthService {
-  MockAuthService({this.isAnonymousValue = false});
+  MockAuthService({
+    this.isAnonymousValue = false,
+    this.hasExpiredOAuthSessionValue = false,
+  });
 
   final bool isAnonymousValue;
+  final bool hasExpiredOAuthSessionValue;
 
   @override
   bool get isAnonymous => isAnonymousValue;
@@ -96,7 +100,7 @@ class MockAuthService extends Mock implements AuthService {
       Stream.value(AuthState.authenticated);
 
   @override
-  bool get hasExpiredOAuthSession => false;
+  bool get hasExpiredOAuthSession => hasExpiredOAuthSessionValue;
 }
 
 const testUserHex =
@@ -152,8 +156,12 @@ void main() {
       bool isAnonymous = false,
       String? displayNameHint,
       String? avatarUrlHint,
+      bool hasExpiredSession = false,
     }) {
-      final authService = MockAuthService(isAnonymousValue: isAnonymous);
+      final authService = MockAuthService(
+        isAnonymousValue: isAnonymous,
+        hasExpiredOAuthSessionValue: hasExpiredSession,
+      );
 
       Widget header = ProfileHeaderWidget(
         userIdHex: userIdHex,
@@ -613,6 +621,44 @@ void main() {
         final button = tester.widget<ElevatedButton>(registerButton);
         expect(button.onPressed, isNotNull);
       });
+
+      testWidgets('session expired banner can be dismissed and stays hidden', (
+        tester,
+      ) async {
+        final testProfile = createTestProfile(displayName: 'Test User');
+
+        SharedPreferences.setMockInitialValues({});
+
+        await tester.pumpWidget(
+          buildTestWidget(
+            userIdHex: testUserHex,
+            isOwnProfile: true,
+            profile: testProfile,
+            hasExpiredSession: true,
+          ),
+        );
+        await tester.pumpAndSettle();
+
+        expect(find.text('Session Expired'), findsOneWidget);
+
+        await tester.tap(find.byIcon(Icons.close));
+        await tester.pumpAndSettle();
+
+        expect(find.text('Session Expired'), findsNothing);
+
+        // Rebuild and ensure persisted dismissal hides the banner
+        await tester.pumpWidget(
+          buildTestWidget(
+            userIdHex: testUserHex,
+            isOwnProfile: true,
+            profile: testProfile,
+            hasExpiredSession: true,
+          ),
+        );
+        await tester.pumpAndSettle();
+
+        expect(find.text('Session Expired'), findsNothing);
+      });
     });
   });