Link model's target field collides with the `cms.api.add_plugin` target parameter

[fsbraun]

The target field of the Link model probably should be renamed to link_target, or it cannot be used with the Django CMS' API:

def add_plugin(placeholder, plugin_type, language, position="last-child", target=None, **data):
    """
    Adds a plugin to a placeholder and returns it.

    :param placeholder: Placeholder to add the plugin to
    :type placeholder: :class:`cms.models.placeholdermodel.Placeholder` instance
    :param plugin_type: What type of plugin to add
    :type plugin_type: str or :class:`cms.plugin_base.CMSPluginBase` sub-class, must be a valid plugin
    :param str language: Language code for this plugin, must be in :setting:`django:LANGUAGES`
    :param str position: Position to add this plugin to the placeholder. Allowed positions are ``"last-child"``
                         (default), ``"first-child"``, ``"left"``, ``"right"``.
    :param target: Parent plugin. Must be plugin instance
    :param data: Data for the plugin type instance
    """

The alternative - renaming the add_plugin target parameter into parent is a breaking change and not desired for the API.

Thanks, @mrbazzan for pointing this out in django-cms/djangocms-transfer#43

[dnlzrgz]

Hi! I wanted to give this issue a try but I've hit a small bump when trying to run the migration after updating the model field to start updating the tests and making sure everything works as expected before making a PR. I am sorry if there is any part of the documentation that already says how to it, but I don't know the recommended workflow for generating the migrations for cases like this

[fsbraun]

@dnlzrgz Creating migrations for a reusable Django app is somewhat awkward. Here are my favorite ways on descending order of preference:

1. Create a dummy project and install the app (djangocms-link) in your case using pip install -e /path/to/your/repo/clone. Then run ./manage.py makemigrations from your dummy app.
2. Use the existing test environment. Temporarily modify the the test_migrations.py test: In line 24 & 26 remove the options. This runs the makemigrations command in the test environment. Do not forget to undo the changes to test_migrations.py.
3. Use a mini script file like discussed here on stack overflow:

# make_migrations.py

import os
import sys

if __name__ == "__main__":
    os.environ.setdefault("DJANGO_SETTINGS_MODULE", "tests.settings")
    from django.core.management import execute_from_command_line
    args = sys.argv + ["makemigrations", "your_app"]
    execute_from_command_line(args)

[dnlzrgz]

I see! Thanks a lot!

If it's okay then if I make a PR to try to fix this issue?

[fsbraun]

Absolutely! I am looking forward to it!