Placeholder Serializer Ignores Plugin "serialize" Implementations

[kid-c-plus]

The Placeholder serializer checks for, in order, a "serializer" object and a "serialize" method in the provided plugin in the "render_plugin" method (serializers/placeholder.py, line 173). It will call either or both of these, and save the result to the variable "json". However, this output is always overwritten by the catch-all PluginSerializer.

[fsbraun]

@kid-c-plus Thanks for raising an issue. I am not sure I fully understand, is this about the (lack of) code beauty here:

djangocms-rest/djangocms_rest/serializers/placeholder.py

Lines 177 to 182 in 2341be5

	if hasattr(instance, "serializer") and issubclass(
	instance.serializer, serializers.Serializer
	):
	json = instance.serializer(instance, context=context).data
	if hasattr(instance, "serialize"):
	json = instance.serialize(context=context)

Or, did you notice a malfunction?

[kid-c-plus]

Thank you for your response! I fear I may be misunderstanding this snippet, but I don’t see why the return value, json, is always overwritten later on line 197 by the value of PluginSerializer.data. I defined my own “serialize” method in the model for a plugin I was working with, and I found that though the method was called, the actual output in the relevant placeholder in the API came from PluginSerializer, not the output of “serialize”. Is this by design?

[kid-c-plus]

Just checking in - were you able to look into this?

[fsbraun]

@kid-c-plus Thanks for asking! The serializers have just been refactored quite a bit by @metaforx and I believe the issue is gone. Do you want to take a look.

[kid-c-plus]

Thanks for your response! I saw that and wasn't sure if it included this. I'll test and update this issue.

[metaforx]

@kid-c-plus please test refactored version and report if you still encounter issues. If so, please add some sample code of your custom serializer. But it might be resolved already (unintentionally) with refactoring of djangocms-rest.