Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CachePanel: monkeypatch Django's caches across sys.modules #982

Closed
wants to merge 6 commits into from
Closed

CachePanel: monkeypatch Django's caches across sys.modules #982

wants to merge 6 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 1, 2017 •
edited
Loading

Fixes #799.

TODO:

  • cleanup (consistent naming)
  • test(s)

@blueyed blueyed force-pushed the cache-patch-modules branch from d1eb92e to c909852 Compare August 1, 2017 20:48
@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #982 into master will decrease coverage by 2.41%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   83.46%   81.04%   -2.42%     
==========================================
  Files          28       28              
  Lines        1578     1583       +5     
  Branches      235      236       +1     
==========================================
- Hits         1317     1283      -34     
- Misses        192      221      +29     
- Partials       69       79      +10
Impacted Files Coverage Δ
debug_toolbar/panels/cache.py 74.41% <78.57%> (-7.04%) ⬇️
debug_toolbar/compat.py 50% <0%> (-50%) ⬇️
debug_toolbar/management/commands/__init__.py 66.66% <0%> (-16.67%) ⬇️
debug_toolbar/panels/sql/utils.py 70.65% <0%> (-13.18%) ⬇️
debug_toolbar/panels/headers.py 95.45% <0%> (-4.55%) ⬇️
debug_toolbar/panels/templates/panel.py 86.4% <0%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ddc7b...7268b2c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #982 into master will decrease coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   83.46%   83.45%   -0.01%     
==========================================
  Files          28       28              
  Lines        1578     1584       +6     
  Branches      235      237       +2     
==========================================
+ Hits         1317     1322       +5     
- Misses        192      193       +1     
  Partials       69       69
Impacted Files Coverage Δ
debug_toolbar/panels/cache.py 81.53% <93.33%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ddc7b...45b1de3. Read the comment docs.

@blueyed blueyed force-pushed the cache-patch-modules branch from 0070c2f to 692f630 Compare August 4, 2017 10:43
@blueyed blueyed requested a review from aaugustin August 6, 2017 12:53
@matthiask
Copy link
Member

This might work, but looks really really evil :-/

@matthiask matthiask mentioned this pull request Sep 6, 2017
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Sep 6, 2017

Maybe #800 would be less intrusive then?
I was not aware that I did another PR already when doing this one..

@camilonova
Copy link
Contributor

@blueyed could you please update this PR and fix the conflicts?

@blueyed
Copy link
Contributor Author

blueyed commented Jul 22, 2018

Would be good to get a go considering its "evil-ness" before.
/cc @matthiask @aaugustin

@aaugustin
Copy link
Contributor

Aside from a general feeling that this could cause issues, I don't have a strong opinion on this. If you're ready to support users after this change, you can merge it.

Base automatically changed from master to main February 11, 2021 15:01
@matthiask
Copy link
Member

The relevant code has changed a lot in this area. Please resubmit if you still want to work on this. Thanks in advance!

@matthiask matthiask closed this Sep 16, 2022
@blueyed blueyed deleted the cache-patch-modules branch November 3, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaugustin aaugustin Awaiting requested review from aaugustin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache panel does not handle imported "caches" on module level
4 participants
@blueyed @matthiask @camilonova @aaugustin