Open
Description
Hi @smithdc1 and @carltongibson
am I wrong or don't we validate the linting rules in our CI pipeline?
There is something in the per-pyhton-version setup but apparently, it's not being executed.
Futhermore, linting should / can be checked version-independly, right?
What's your take on this?
Best
Ronny
Activity
carltongibson commentedon Feb 10, 2024
See here: https://github.com/django-crispy-forms/crispy-tailwind/actions/runs/7828342050/job/21358001447
Latest successful run, Python 3.12. Linters are executed.
That corresponds to the workflow file:
For me, we only need to run these for a single Python version.
So LGTM, I'd say.
GitRon commentedon Feb 11, 2024
Hi @carltongibson!
Thanks for the explanation! That's a novel setup to me! I was discussing in another ticket that an HTML linter might come in handy, therefore I looked a the setup.
So a couple of thoughts/question here:
Best
Ronny
carltongibson commentedon Feb 11, 2024
My preference is to keep configs in the tox file. The workflows just then call out to that. I'm not a fan of putting everything via pre-commit, though I know others think differently.
I'd rather not shift to ruff. It's controlled by a VC funded private company, and (as nice as the folks might be) the bill for that will become due one day. I would rather use community tools.
I'm not quite sure what you have in mind for the other points... Like, maybe 😅 — I think the idea with the current setup is to avoid running the linter step redundantly for every Python version. (Once is enough there)
GitRon commentedon Feb 11, 2024
Good point. I would still do it differently but see your point. We keep it as it is.
That's true. Ok, we stick with it for now.
Sorry 😅 Here's a screenie of "my" setup. The linting just runs intependently of the unittests and I don't need the if-condition, still it only runs once per pipeline.
carltongibson commentedon Feb 11, 2024
Yeah, if you can simplify, let's have it! 👍
GitRon commentedon Feb 11, 2024
Great, so I'll sum up:
Thx @carltongibson for your input! ❤️
carltongibson commentedon Feb 11, 2024
Not sure I did much. 😅
Thanks for your energy @GitRon 🎁
django-crispy-forms#158: Optimise CI linting
django-crispy-forms#158: Added linting to "needs" section of deploy job
#158: Optimise CI linting (#159)
smithdc1 commentedon Feb 11, 2024
I completely agree 💯
Thank you!