Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followed platform conventions for showing search shortcut key #1961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

medmunds
Copy link

Changed display of the search shortcut key to "⌘ K" on Mac and "Ctrl+K" elsewhere.

Fixes #1960.

Copy link
Member

@adamzap adamzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this suggestion!

Changed display of the search shortcut key to "⌘ K" on Mac and "Ctrl+K" elsewhere.

(\u200a is a hair space, which looks better than a full space or no space.)

Fixes django#1960.
@medmunds
Copy link
Author

I went with a hair space between the ⌘ and the K. A full space seemed too wide and no space seemed too narrow.

Screenshot of search box in Safari comparing spacing between ⌘ and K, for full space, thin space, hair space, and no space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs searchbox shortcut formatted wrong on Mac
3 participants