fixed janky handling of gzipped content returned with non-standard headers

Author: djcass44

pkg/requestutil/decompress.go

@@ -11,15 +11,18 @@ import (
 	"github.com/mholt/archives"
 )
 
-const ContentTypeGzip = "application/gzip"
+var ContentTypesGzip = []string{
+	"application/gzip",
+	"application/x-gzip",
+}
 
 func WithGzip(out io.Writer) requests.ResponseHandler {
 	return func(response *http.Response) error {
 		log := logr.FromContextOrDiscard(response.Request.Context())
 		var stream io.ReadCloser
 
 		// if it's a gzip response, decompress it
-		if mimetype.EqualsAny(response.Header.Get("Content-Type"), ContentTypeGzip) {
+		if isGzipped(response.Header.Get("Content-Type")) {
 			log.V(8).Info("decompressing gzip response")
 			dec, err := archives.Gz{}.OpenReader(response.Body)
 			if err != nil {
@@ -37,3 +40,7 @@ func WithGzip(out io.Writer) requests.ResponseHandler {
 		return nil
 	}
 }
+
+func isGzipped(s string) bool {
+	return mimetype.EqualsAny(s, ContentTypesGzip...)
+}

pkg/requestutil/decompress_test.go

@@ -0,0 +1,34 @@
+package requestutil
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestIsGzipped(t *testing.T) {
+	var cases = []struct {
+		s  string
+		ok bool
+	}{
+		{
+			"application/gzip",
+			true,
+		},
+		{
+			"application/x-gzip",
+			true,
+		},
+		{
+			"application/javascript",
+			false,
+		},
+	}
+
+	for _, tt := range cases {
+		t.Run(tt.s, func(t *testing.T) {
+			ok := isGzipped(tt.s)
+			assert.EqualValues(t, tt.ok, ok)
+		})
+	}
+}