Only include x264 and libvpx when they are needed

[fcecagno]

Hi there,

Thank you for this cookbook, it works really great. I have a suggestion that would make it a little better. Instead of just include the recipes x264 and libvpx, you could check if --enable-libx264 and --enable-libvpx are present in the compile flags - if they are not, there's no reason to include the recipes, right? Something as simple as the code below. Thank you.

if node[:ffmpeg][:compile_flags].include? '--enable-libx264'
include_recipe "x264::source"
end
if node[:ffmpeg][:compile_flags].include? '--enable-libvpx'
include_recipe "libvpx::source"
end

[djoos]

Hi @fcecagno,

I'm the new maintainer of the ffmpeg cookbook and I hope to get back to you on this issue within the next few weeks...

Kind regards,
David

[fcecagno]

Thanks @djoos!

[fcecagno]

Please let me know if you are interested in merge such improvement and I can send a pull request.

[djoos]

Hi Felipe,

I'm actually not too sure whether x264 and libvpx should be included (include_recipe) in this cookbook.
For instance: I've used the FFMPEG cookbook with the Fraunhofer AAC in the past (recipe: libfdk_aac::source & compile flag: --enable-libfdk_aac) - but IMO the inclusion of x264/libvpx/libfdk_aac and many other potential compile flag combos are outside of the actual ffmpeg cookbook's scope. It would just get too cluttered...

IMO the default compile flags should also be as lean as possible... What do you think?

Thanks in advance for your feedback!

Kind regards,
David

[fcecagno]

Yes, I agree that it's outside of the cookbook's scope and shouldn't be included at all. Also, in my case it will work. :)