Bug apple#39

dkovba · dkovba · commit 25dde976d160 · 2026-03-10T23:15:20.000-07:00
diff --git a/Sources/ContainerizationEXT4/EXT4+Extensions.swift b/Sources/ContainerizationEXT4/EXT4+Extensions.swift
@@ -92,8 +92,11 @@ extension EXT4.XAttrEntry {
 }
 
 extension EXT4 {
+    // Bug #39 (LOW): Was implemented using Mirror reflection — slow, not type-safe, and field
+    // order is not guaranteed to match memory layout across Swift versions.
+    // Fixed to withUnsafeBytes(of: tuple) { Array($0) } which directly reads the memory layout.
+    // Same fix: opus-1m. All other branches use Mirror reflection.
     static func tupleToArray<T>(_ tuple: T) -> [UInt8] {
-        let reflection = Mirror(reflecting: tuple)
-        return reflection.children.compactMap { $0.value as? UInt8 }
+        withUnsafeBytes(of: tuple) { Array($0) }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,11 @@ extension EXT4.XAttrEntry {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`extension EXT4 {`
	`95`	`+ // Bug #39 (LOW): Was implemented using Mirror reflection — slow, not type-safe, and field`
	`96`	`+ // order is not guaranteed to match memory layout across Swift versions.`
	`97`	`+ // Fixed to withUnsafeBytes(of: tuple) { Array($0) } which directly reads the memory layout.`
	`98`	`+ // Same fix: opus-1m. All other branches use Mirror reflection.`
`95`	`99`	`static func tupleToArray<T>(_ tuple: T) -> [UInt8] {`
`96`		`- let reflection = Mirror(reflecting: tuple)`
`97`		`- return reflection.children.compactMap { $0.value as? UInt8 }`
	`100`	`+ withUnsafeBytes(of: tuple) { Array($0) }`
`98`	`101`	`}`
`99`	`102`	`}`