Address code review feedback: improve error handling and boundary conditions

Co-authored-by: vcastellm <47026+vcastellm@users.noreply.github.com>

Author: Copilot

extcron/after.go

@@ -30,9 +30,9 @@ func (schedule AfterSchedule) Next(t time.Time) time.Time {
 		return schedule.Date
 	}
 
-	// If we're within the grace period, run immediately
+	// If we're within the grace period (including the exact end moment), run immediately
 	gracePeriodEnd := schedule.Date.Add(schedule.GracePeriod)
-	if t.Before(gracePeriodEnd) {
+	if !t.After(gracePeriodEnd) {
 		return t
 	}
 

extcron/after_test.go

@@ -36,6 +36,13 @@ func TestAfterScheduleNext(t *testing.T) {
 			currentTime: "2020-01-01T01:59:59Z",
 			expected:    "2020-01-01T01:59:59Z", // Returns current time (immediate)
 		},
+		{
+			name:        "exactly at end of grace period - should run immediately",
+			scheduleAt:  "2020-01-01T00:00:00Z",
+			gracePeriod: 2 * time.Hour,
+			currentTime: "2020-01-01T02:00:00Z",
+			expected:    "2020-01-01T02:00:00Z", // Returns current time (immediate)
+		},
 		{
 			name:        "after grace period - should never run",
 			scheduleAt:  "2020-01-01T00:00:00Z",

extcron/duration.go

@@ -27,37 +27,55 @@ func ParseISO8601Duration(s string) (time.Duration, error) {
 
 	// Years (approximate: 365 days)
 	if matches[1] != "" {
-		years, _ := strconv.Atoi(matches[1])
+		years, err := strconv.Atoi(matches[1])
+		if err != nil {
+			return 0, fmt.Errorf("invalid year value: %s", matches[1])
+		}
 		duration += time.Duration(years) * 365 * 24 * time.Hour
 	}
 
 	// Months (approximate: 30 days)
 	if matches[2] != "" {
-		months, _ := strconv.Atoi(matches[2])
+		months, err := strconv.Atoi(matches[2])
+		if err != nil {
+			return 0, fmt.Errorf("invalid month value: %s", matches[2])
+		}
 		duration += time.Duration(months) * 30 * 24 * time.Hour
 	}
 
 	// Days
 	if matches[3] != "" {
-		days, _ := strconv.Atoi(matches[3])
+		days, err := strconv.Atoi(matches[3])
+		if err != nil {
+			return 0, fmt.Errorf("invalid day value: %s", matches[3])
+		}
 		duration += time.Duration(days) * 24 * time.Hour
 	}
 
 	// Hours
 	if matches[4] != "" {
-		hours, _ := strconv.Atoi(matches[4])
+		hours, err := strconv.Atoi(matches[4])
+		if err != nil {
+			return 0, fmt.Errorf("invalid hour value: %s", matches[4])
+		}
 		duration += time.Duration(hours) * time.Hour
 	}
 
 	// Minutes
 	if matches[5] != "" {
-		minutes, _ := strconv.Atoi(matches[5])
+		minutes, err := strconv.Atoi(matches[5])
+		if err != nil {
+			return 0, fmt.Errorf("invalid minute value: %s", matches[5])
+		}
 		duration += time.Duration(minutes) * time.Minute
 	}
 
 	// Seconds (can be fractional)
 	if matches[6] != "" {
-		seconds, _ := strconv.ParseFloat(matches[6], 64)
+		seconds, err := strconv.ParseFloat(matches[6], 64)
+		if err != nil {
+			return 0, fmt.Errorf("invalid second value: %s", matches[6])
+		}
 		duration += time.Duration(seconds * float64(time.Second))
 	}