Some Release fixes

- Removed staging Player B states which resulted in possible null pointers
- Increased name length limit
- Updated Iron Curtain Check to use correct data member
- Added explosions for Iron Curtain Hit List when active.

Author: dlweatherhead

Assets/EC2018/CommandLineUtil.cs

@@ -6,7 +6,7 @@ public static class CommandLineUtil
 	{
 		const string RoundStep = "-round-step";
 
-		const float defaultRoundStep = 1.5f;
+		const float defaultRoundStep = 1f;
 
 		public static float GetRoundStep() {
 			var args = System.Environment.GetCommandLineArgs ();

Assets/EC2018/CountInDetailPopulator.cs

@@ -8,7 +8,7 @@ public class CountInDetailPopulator : MonoBehaviour {
 
     public TextMeshProUGUI tmpPlayerA;
     public TextMeshProUGUI tmpPlayerB;
-    public int MaxLength = 20;
+    public int MaxLength = 31;
 
 	void Start () {
         tmpPlayerA.text = GetPlayerName (PlayerType.A);

Assets/EC2018/Entities/Player.cs

@@ -14,5 +14,6 @@ public class Player
         public int Score { get; set; }
 		public bool IronCurtainAvailable { get; set; }
 		public int ActiveIronCurtainLifetime { get; set; }
+        public bool IsIronCurtainActive { get; set; }
     }
 }

Assets/EC2018/GameStateManager.cs

@@ -169,7 +169,10 @@ public void PlayCurrentState() {
                 }
             }
 
-            ProcessIronCurtainHitList(gameState.Players);
+            if(currentRound > 0) {
+                ProcessIronCurtainHitList(gameState.Players);    
+            }
+
             if (CanIncrementRound()) {
                 currentRound++;
             } else {
@@ -193,9 +196,14 @@ void ProcessTeslaHitList(List<List<HitList>> hitLists) {
 
         void ProcessIronCurtainHitList(List<Player> players) {
             for (int i = 0; i < players.Count; i++) {
-                var available = players[i].IronCurtainAvailable;
-                var lifetime = players[i].ActiveIronCurtainLifetime;
-                if (available && lifetime >= 0) {
+                if (players[i].IsIronCurtainActive) {
+
+                    var hitList = gameState.IroncurtainHitList;
+
+                    for (int h = 0; h < hitList.Count; h++) {
+                        instantiator.InstantiateExplosion(7.5f, hitList[h].Y, hitList[h].PlayerType);
+                    }
+                        
                     instantiator.ActivateIronCurtain(players[i].PlayerType);
                 } else {
                     instantiator.DeactivateIronCurtain(players[i].PlayerType);

Assets/EC2018/Instantiator.cs

@@ -155,6 +155,12 @@ private void InstantiateLightningHit(PlayerType originPlayer, GameObject start,
             expObj.transform.localScale = expObj.transform.localScale * 0.5f;
         }
 
+        public void InstantiateExplosion(float x, float y, PlayerType player) {
+            var explosionToInstantiate = player == PlayerType.B ? explosionA : explosionB;
+            var expObj = Instantiate(explosionToInstantiate, new Vector3(x, 0.5f, y), Quaternion.identity);
+            expObj.transform.localScale = expObj.transform.localScale * 0.5f;
+        }
+
         public void InstantiateTeslaHit(List<HitList> hitList, Player playerA, Player playerB) {
 
             // if list is empty

Assets/EC2018/ReplayManager.cs

@@ -29,8 +29,7 @@ void LoadAllRounds() {
         for (int roundNumber = 0; roundNumber < numberOfRounds; roundNumber++) {
             var roundName = ConvertRoundToFolderName(roundNumber);
             var statePlayerA = GetGameStateForPlayer(0, replayPath, roundName);
-            var statePlayerB = GetGameStateForPlayer(1, replayPath, roundName);
-            var round = new Round(statePlayerA, statePlayerB);
+            var round = new Round(statePlayerA, null);
             rounds.Add(round);
         }
     }

Assets/EC2018/UIManager.cs

@@ -34,7 +34,7 @@ public class UIManager : MonoBehaviour {
         public BarrierHealth barrierHealthA;
         public BarrierHealth barrierHealthB;
 
-        public int MaxLength = 20;
+        public int MaxLength = 31;
 
         GameManager gameManager;