Skip to content

Argument mismatch in deployment script of CCIP-Resolver #1201

@bhagatkabir

Description

@bhagatkabir

Issue Found in CCIP-Resolver Repository's Main Branch

Issue:
The current deployment script is unable to deploy the CCIP Verifier Contract. I am not sure if the main branch has latest code pushed or not. But following this scripts of deployment I don't think anyone should be able to deploy the contracts.

Details:
Following the setup steps in Pragati's documentation, there is a step to deploy the Signature CCIP Verifier contract using the command:

npx hardhat run ./deploy/04_SignatureCcipVerifier.ts --network <network_name>

However, running this command results in the following error:

Error: invalid BigNumber string (argument="value", value="SignatureCcipVerifier", code=INVALID_ARGUMENT, version=bignumber/5.7.0)

Root Cause:
Upon investigating, I found a mismatch between the argument order in the deployment script and the contract's constructor. Specifically, in the deployment script, we pass the ResolverChainID as the third argument, but the contract’s constructor expects it as the fourth argument. This misalignment is causing the deployment to fail.

Impact
This is an issue, as it prevents the successful deployment of the Signature CCIP Verifier contract. Resolving this should be a top priority. I'm also surprised that this wasn't encountered when Pragati was initially setting up the resolver and documenting the process.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions