request to merge fork features here

[ReenigneArcher]

I have a fork of this repo (https://github.com/LizardByte/tray), that we use for Sunshine. I never intended to maintain this fork for long, and I'm opening this issue in hopes of merging features into this branch.

This is a list of all the changes (many of these can be ignored though): master...LizardByte:tray:master

My best guess summary is below:

Important Features/Fixes

• balloon/notification system
• Perform all GTK interactions on the tray loop thread LizardByte/tray#9
• Allow tray icons to be precached. LizardByte/tray#10
• Fix for missing small icon infinite recursion LizardByte/tray#12
• fix(linux): cast notification callback with NOTIFY_ACTION_CALLBACK LizardByte/tray#56

Less important

• feat: add unit testing and standardize to org LizardByte/tray#13
  • add unit tests (I used googletest as I was most familiar with in from other projects, though I could use a different test framework if necessary)
  • add code coverage (We use https://about.codecov.io/ which offers a free service for open source... https://app.codecov.io/gh/LizardByte/tray)
  • move/refactor code into a defined directory structure
    • source code into src
    • docs/images into docs
    • icon files into icons
  • lint code
    • clang-format
    • cmake-lint
• docs: add doxygen docs LizardByte/tray#21 (example: https://docs.lizardbyte.dev/projects/tray/latest/)
  • docs via doxygen
  • build and host on readthedocs (alternatively could host on gh-pages)

This is not all inclusive of every PR, but should give a general idea. Would you be willing to consider a series of PRs that brings the features we need over here? If so, is there anything on the list you wouldn't accept?

[ReenigneArcher]

Looks like a bunch of these are actually in #18

cgutman's fork was made to contribute to our fork for Sunshine.

[dmikushin]

Hi @ReenigneArcher , thank you for this, but unfortunately I don't fully understand what's going on here . The PR #18 is very difficult to review, does it have to be so complex? If not, may I kindly ask you to upstream your improvements as individual patches. Please do not hesitate to use help of an AI agent.

[ReenigneArcher]

@dmikushin I didn't open #18, it looks like you did?