Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Difference in naming convention between op.py and test_op.py #1580

@AetherPrior

Description

@AetherPrior

Description

Mxnet's NumPy is being imported as np in the file src/gluonnlp/op.py:

from mxnet import np, npx

While NumPy is imported as np in test_op.py:

import numpy as np

This requires a change in conventions between tests and code, which can be a minor nuisance.

What have you tried to solve it?

  1. While a simple refactoring is possible, I don't want to be reverting any design decision in any way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions