Skip to content

Commit 28ce8aa

Browse files
committed
Merge tag 'cam6_4_128' into cam_dustemis_dev
Merge pull request ESCOMP#1355 from jshaw35/hgt_matrix_half_error
2 parents 3d4b7c8 + 4c480c8 commit 28ce8aa

File tree

6 files changed

+646
-397
lines changed

6 files changed

+646
-397
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
url = https://github.com/CFMIP/COSPv2.0
9797
fxrequired = AlwaysRequired
9898
fxsparse = ../.cosp_sparse_checkout
99-
fxtag = v2.1.4cesm
99+
fxtag = v2.1.9
100100
fxDONOTUSEurl = https://github.com/CFMIP/COSPv2.0
101101

102102
[submodule "clubb"]

bld/namelist_files/namelist_defaults_cam.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,7 @@
197197
<ncdata hgrid="ne30np4" nlev="32" chem="trop_strat_mam5_ts2">atm/cam/inic/se/f.e22.FC2010climo.ne30_ne30_mg17.cam6_2_032.001.cam.i.0006-01-01-00000_c200623.nc</ncdata>
198198
<ncdata hgrid="ne30np4" nlev="58" chem="trop_strat_mam5_vbs">atm/cam/inic/se/f.e22.FCnudged.ne30_ne30_mg17.release-cesm2.2.0_spinup.2010_2020.001.cam.i.2011-01-01-00000_L58_c220310.nc</ncdata>
199199
<ncdata hgrid="ne30np4" nlev="58" >atm/cam/inic/se/FLT_L58_ne30pg3_IC_c220623.nc</ncdata>
200-
<ncdata hgrid="ne30np4" nlev="70" >atm/waccm/ic/FW2000_ne30_L70_01-01-0001_c200602.nc</ncdata>
201-
<ncdata hgrid="ne30np4" nlev="70" npg="3" >atm/waccm/ic/FW2000.ne30pg3_ne30pg3_nlev70_c230906.nc</ncdata>
200+
<ncdata hgrid="ne30np4" nlev="70" waccm_phys="1" >atm/waccm/ic/FW2000.ne30pg3_ne30pg3_nlev70_c230906.nc</ncdata>
202201
<ncdata hgrid="ne30np4" nlev="93" >atm/cam/inic/se/c153_ne30pg3_FMTHIST_x02.cam.i.1990-01-01-00000_c240618.nc</ncdata>
203202
<ncdata hgrid="ne30np4" nlev="93" chem="trop_strat_mam5_vbs">atm/cam/inic/se/f.cam6_3_160.FCMT_ne30.moving_mtn.001.cam.i.1996-01-01-00000_c240618.nc</ncdata>
204203
<ncdata hgrid="ne30np4" nlev="110" >atm/waccm/ic/FWsc2000_ne30pg3_L110_01-01-0001_c200521.nc</ncdata>

cime_config/testdefs/testmods_dirs/cam/cosp_rad_diags/user_nl_cam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ cosp_histfile_aux=.true.
99
cosp_histfile_aux_num=3
1010
fexcl2='CFAD_DBZE94_CS','CLDTOT_CALCS','CLD_CAL_NOTCS','CS_MIXCERT','CS_MIXPOSS','CS_NOPRECIP',
1111
'CS_PIA','CS_RAINPOSS','CS_RAINPROB','CS_RAINCERT','CS_RAINHARD','CS_SNOWCERT','CS_SNOWPOSS',
12-
'CS_UN'
12+
'CS_UN', 'CS_WR_CFODD_REFF_LARGE'
1313

1414
mode_defs=
1515
'mam4_mode1:accum:=', 'A:num_a1:N:num_c1:num_mr:+',

doc/ChangeLog

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,77 @@
11
===============================================================
22

3+
Tag name: cam6_4_128
4+
Originator(s): jshaw35, fvitt, cacraig, nusbaume
5+
Date: Oct 30, 2025
6+
One-line Summary: Correct allocation and assignment error for 'hgt_matrix_half' field in cospsimulator_intr.F90
7+
Github PR URL: https://github.com/ESCOMP/CAM/pull/1355
8+
9+
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
10+
- Fix bug where CAM height interfaces were incorrectly passed to COSP (requires COSP update):
11+
https://github.com/ESCOMP/CAM/issues/1354
12+
- Bring in an updated default WACCM IC file for the ne30 grid:
13+
https://github.com/ESCOMP/CAM/issues/1425
14+
15+
Describe any changes made to build system: N/A
16+
17+
Describe any changes made to the namelist: N/A
18+
19+
List any changes to the defaults for the boundary datasets: N/A
20+
21+
Describe any substantial timing or memory changes: N/A
22+
23+
Code reviewed by: eaton, brianpm, jedwards
24+
25+
List all files eliminated: N/A
26+
27+
List all files added and what they do: N/A
28+
29+
List all existing files that have been modified, and describe the changes:
30+
31+
M .gitmodules
32+
M src/physics/cosp2/src
33+
- Update COSP submodule to version 2.1.9
34+
35+
M src/physics/cam/cospsimulator_intr.F90
36+
- Fix 'hgt_matrix_half' bug, and add new COSP diagnostic fields to
37+
CAM history output.
38+
39+
M bld/namelist_files/namelist_defaults_cam.xml
40+
- Use spun-up default WACCM IC file for the ne30 grid.
41+
42+
M cime_config/testdefs/testmods_dirs/cam/cosp_rad_diags/user_nl_cam
43+
- Add 'CS_WR_CFODD_REFF_LARGE' to fexcl list in COSP ERC test in order
44+
to allow tests to pass (CloudSat variables appear to be task-dependent).
45+
46+
47+
If there were any failures reported from running test_driver.sh on any test
48+
platform, and checkin with these failures has been OK'd by the gatekeeper,
49+
then copy the lines from the td.*.status files for the failed tests to the
50+
appropriate machine below. All failed tests must be justified.
51+
52+
derecho/intel/aux_cam:
53+
54+
ERC_D_Ln9.f19_f19_mt232.QPC6.derecho_intel.cam-outfrq3s_cosp (Overall: DIFF)
55+
- COSP answer changes due to bug fix and new COSP submodule
56+
57+
derecho/nvhpc/aux_cam: ALL PASS
58+
59+
izumi/nag/aux_cam:
60+
61+
ERC_D_Ln9.f10_f10_mt232.FHIST.izumi_nag.cam-outfrq3s_cospsathist (Overall: DIFF)
62+
ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHISTC_LTso.izumi_nag.cam-cosp_rad_diags (Overall: DIFF)
63+
- COSP answer changes due to bug fix and new COSP submodule
64+
65+
izumi/gnu/aux_cam:
66+
67+
ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHIST_C5.izumi_gnu.cam-carma_cosp_rad_diag_mam (Overall: DIFF)
68+
- COSP answer changes due to bug fix and new COSP submodule
69+
70+
Summarize any changes to answers: COSP answer changes validated by Brian Medeiros (brianpm)
71+
72+
===============================================================
73+
===============================================================
74+
375
Tag name: cam6_4_127
476
Originator(s): courtneyp, jedwards
577
Date: Oct 24, 2025

0 commit comments

Comments
 (0)